Needs work
Project:
CAPTCHA
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
4 Jul 2012 at 13:19 UTC
Updated:
21 Nov 2022 at 15:13 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
rogical commentedGood! Why don't you create a sandbox and apply to be a module?
Comment #2
Belaselm commentedThat's probably because I can't access the git repository. (I could, but it seems I did something wrong, and the repository refuses the connection.) Anyway, this captcha is almost identical in code to the image captcha, and the applying rules say that in this case I'm to contact the authors of the original module, and offer it as a contribution/patch.
Comment #3
rogical commentedThen you can try to make a patch or upload a tarball first. However, git is a must in drupal development.
Comment #4
wundo commentedrogical, could you upload a patch?
Comment #5
Belaselm commentedYes, I know, but I have just started using git, and I'm not perfect from it yet. For now, I'm attaching a tarball archive. I'll also have two more captchas soon, I'll try to make them as independent modules.
Comment #6
rogical commentedTested, seems all well.
Comment #7
Belaselm commentedSorry, I have left some obsolete parts in the code, like UTF-8 split, which is unnecessary for numbers. Here is a modified version without these.
Comment #8
rogical commentedNew files seems can't to be made in patch.
Comment #9
Belaselm commentedSorry, as I wrote I'm still new in this business. Will this diff to the originally uploaded graphmath_captcha.tar_.gz file be enough?
Comment #10
Belaselm commentedI have created a sandbox project, and uploaded the files of this GraphMath CAPTCHA there. You can find it at http://drupalcode.org/sandbox/Belaselm/1676284.git/
Comment #11
Belaselm commentedI have created a git patch from the proposed graphmath_captcha submodule. I hope it will be OK.
Comment #12
soxofaan commentedHi,
sorry for the delayed answer. Looking at the patch of #11, I think there is way too much code duplication with the image CAPTCHA module. It would be pretty bad for long term maintainability to do it like this. Why didn't you reuse the functions from image CAPTCHA directly?
Comment #13
Belaselm commentedThanks for the suggestion, I'll work on it when I'll have some time. I thought about making this captcha a part of the image captcha module, along with a configuration option to select it, but if we keep it a submodule, it can be used alongside the image captcha.
Comment #14
adams.garfield commentedGr8 work Belaselm. Captchas are pretty hard to code..
Comment #15
chris matthews commentedVersion change only
Comment #16
anybody@Belaselm could you please add your implementation as merge-request for review?
As I'm not maintaining the 7.x branch, someone else will have to review this one then.