i18n_node_type_enabled is incompatible with Entity Translation (field translation) type

Right, we don't mess with ET nodes anymore which fixes some other issues.

@Jose Reyero: may I ask you to elaborate on comment #2? The problem still seems to exist and the patch from #1 looks viable, but may effect other functions wrongly.

See _i18n_node_form_node_form_alter(): to allow higher values than 2 for language_content_type_NODE_TYPE (Entity Translation uses ie. 4), maybe the first IF statement could be altered from:

if (i18n_node_type_enabled($node)) {

to:

if (variable_get('language_content_type_' . $node->type, 0)) {

Also see:

1. #1669494: Selecting language in new node and saving, keeps node language neutral
2. #1852102-22: Clarify that Multilingual Content (i18n_node) and ET are not compatible (comments #22 and #23 are on this subject)

Switching to active as this is still an issue (see #1852102: Clarify that Multilingual Content (i18n_node) and ET are not compatible) just as reported in #3.
Comment #23 here proposes a simple solution for it https://www.drupal.org/node/1852102#comment-9612303

Bump.. (see above comment)

Yes, this function should not report no translation support, if there are other modules like entity adding other kind of support.
Why is it limited to 1, and 2 ? why not everything else than 0 ?

For the moment we have to correct things, like in #1852102: Clarify that Multilingual Content (i18n_node) and ET are not compatible

I recently upgraded my content types to ET (entity translation) and I did not observe this issue. ?

hmm

here's the version of entity_translation I use:

projects[entity_translation][version] = 1.0-beta5
projects[entity_translation][subdir] = contrib
projects[entity_translation][patch][2557429] = https://www.drupal.org/files/issues/static_cache_for-2557429-17.patch
projects[entity_translation][patch][2734295] = https://www.drupal.org/files/issues/entity_translation-2734295-4.patch

Here is a patch from the code that Cyclodex provided.

Whoops, wrong Version. Patch is for 7.x-1.12

I had to make these changes to the patch:

remove this line

  a/i18n/i18n_node/i18n_node.module b/i18n/i18n_node/i18n_node.module

replace with this line

  a/i18n_node/i18n_node.module b/i18n_node/i18n_node.module

passes simple tests

needs review by humans

Thanks to @srclarkx for the original patch

Actually thanks to Cyclodex. I needed to get a patch together for our language people to do some testing. I'll use the clean patch when we actually deploy. Thanks! I'll let you know how it works after it makes it through the process and onto our server.

Review by a human and works for me!
Thanks

Thanks srclarkx for creating a patch of my mentioned changes!
And really nice community behaviour to mention me, thanks a lot, hope my changes are correct and helps :) !

excellent work everyone. this will hopefully make it into 7.x-1.15 which has been stalled pending the community feedback of the 7.x-1.x dev branch. Probably release 7.x-1.15 early 2017