Over in commerce_authnet #1154294: Add support for eCheck.Net avr created an eCheck.Net gateway with a basic default form. I've also started to use that for JetPay gateways, so I'd like to move that portion out of that issue queue.

Patch to follow with minor fixes.

CommentFileSizeAuthor
#1 commerce-payment-echeck-form-1661548-1.patch6.42 KBglennpratt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

glennpratt’s picture

glennpratt CreditAttribution: glennpratt commented
FileSize
commerce-payment-echeck-form-1661548-1.patch6.42 KB
glennpratt’s picture

glennpratt CreditAttribution: glennpratt commented
Status: Active » Needs review
vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Needs review » Closed (won't fix)

as Ryan said "a separate module within this project (Commerce Authorize.Net) : #1154294-3: Add support for eCheck.Net
so your patch should be on Commerce Authorize.Net's issue.

glennpratt’s picture

glennpratt CreditAttribution: glennpratt commented
Status: Closed (won't fix) » Needs review

Why would a default eCheck/ACH *form* warrant a separate module? This isn't a payment gateway implementation.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented

i didn't say it is. let's see a second opinion about this.
but i still think this will not be "approved" as drupal commerce core part.

andyg5000’s picture

andyg5000
he/him
Primary language English
Location North Carolina, USA
CreditAttribution: andyg5000 commented

I'm can agree with both sides of the argument here. What about creating a commerce_echeck module and making it a standard dependency for echeck implementations at the payment gateway level?

rszrama’s picture

rszrama CreditAttribution: rszrama commented

I'm not sure I really represented the "other side" of the argument. I'm fine having a generic eCheck form in the Payment module that other payment method modules (like Commerce eCheck.Net) could use.

archimedes’s picture

archimedes CreditAttribution: archimedes commented

Given Ryan's response, what's the status of this project? I see nothing has happened for awhile...is the patch working, and it just needs review?

BassistJimmyJam’s picture

BassistJimmyJam CreditAttribution: BassistJimmyJam commented

We've been using this for a while with #1154294 and I've utilized it in commerce_nmi. What do we need to get this moving forward?

merauluka’s picture

merauluka CreditAttribution: merauluka commented
Issue summary: View changes

I also would like to see this committed. It would be nice to have the added functionality without patching Commerce.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented

The 7 year old patch in #1 to commerce_payment.echeck.inc still applies cleanly to the latest commerce 7.x-1.x-dev, but I'm not sure what the status of this issue should be at this point.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro for Liip commented

@Chris2
What you're doing in this queue is not helpful nor appreciated.

Commerce has pages upon pages of patches. Bumping the issues only creates noise for us maintaners, it doesn't help us prioritize them in any way.

andyg5000’s picture

andyg5000
he/him
Primary language English
Location North Carolina, USA
CreditAttribution: andyg5000 at Blue Oak Interactive commented
Status: Needs review » Closed (outdated)

Looks like he created a bot or has a lot of time to test each one. I don't think this feedback is necessarily bad, but I don't envy bojanz and his inbox noise.

For this one, I doubt it's going to get added to 1.x at this point. Any payment modules that were hoping for this in commerce core have likely moved on.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented

Sorry about that bojanz, my sincere apologies. I was indeed trying to be helpful by manually testing and replying (no bot) to the 7.x issues with 'Needs review' status in an effort to get patches that do not apply re-rolled so that they can be further tested/reviewed, but I will certainly refrain as I would hate to cause additional problems for you or any other maintainers.