Currently, the %t in the custom css path is replaced using path_to_theme(), but in the context it is called in, the function returns the module path rather than the theme path.

This patch changes the method for replacing %t.

CommentFileSizeAuthor
#4 print-1652098-4.patch724 bytesDavid_Rothstein
#1 custom_css_theme_path_replacement_fix.patch590 bytesmorbiD
custom_css_%t_replacement_fix.patch590 bytesmorbiD

Comments

morbiD’s picture

morbiD commented
StatusFileSize
new custom_css_theme_path_replacement_fix.patch590 bytes

Web server doesn't seem to like that patch filename. Let's try again!

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed

http://drupalcode.org/project/print.git/commit/587142d

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

David_Rothstein’s picture

David_Rothstein commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new print-1652098-4.patch724 bytes

Backported the patch to 7.x-1.x.

I'm not really sure variable_get('theme_default') is correct here (it would probably make more sense to use the current active theme instead?). But for most practical cases, I guess it doesn't matter.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Fixed

Thanks for reminding me that this hadn't been applied to 7.x-1.x and 6.x-1.x

Done now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Clarity