On some panes, the fields.inc is not loaded when the submit handler is called which causes the submission to fail. I have noticed this particularly (maybe only) on panes that have a multi form process, such as a continue button with more settings. Including the fields.inc file in the submit handler seems to eliminate this issue.

CommentFileSizeAuthor
#3 include_fields_inc-1612604-3.patch826 bytesawebb
#1 include_fields_inc-1612604-1.patch668 bytesawebb

Comments

awebb’s picture

awebb commented
Status: Active » Needs review
StatusFileSize
new include_fields_inc-1612604-1.patch668 bytes

Here is a patch against the latest dev branch that adds the include function.

merlinofchaos’s picture

merlinofchaos commented

I think the correct fix is to change the ctools_include('fields') to ctools_form_include. Probably the module_load_include that's there with it needs to be converted to a form_load_include() as well to ensure the files are loaded when cached forms are used.

awebb’s picture

awebb commented
StatusFileSize
new include_fields_inc-1612604-3.patch826 bytes
merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Applied wrong patch, pushed, reverted, applied correct patch, pushed again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Typo