Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mitchell’s picture

FileSize
10 KB

I had trouble creating a diff or patch with git (because of it being in a subdirectory), so here's a tar with a couple of changes I made to Itangalo's module.

mitchell’s picture

Component: Provided Module Integrations » Rules Core
Assigned: Unassigned » klausi
Status: Needs work » Needs review

@klausi: Do you think it makes more sense to have this in Rules or Devel?

klausi’s picture

Status: Needs review » Needs work

I think it is a bit too heavy for devel, so including this with Rules would make sense. Please roll a patch.

sonicthoughts’s picture

Issue summary: View changes

should we continue to use the sandbox?

TR’s picture

Assigned: klausi » Unassigned
Status: Needs work » Needs review
FileSize
4.13 KB

Here's a patch based on #1. Let's see what the testbot says.

TR’s picture

Not surprising that the tests pass, since there are no tests for this new rules_devel module. But it does show coding standards notices - I have reviewed those and nothing in the patch needs to be changed.

Looking for reviewers to test the functionality.

TR’s picture

Version: 7.x-2.x-dev » 8.x-3.x-dev
Status: Needs review » Postponed

After 8 years, no one has found this important enough to review.

D7 Rules is basically in maintenance-only mode right now, as D7 is nearing its end-of-life. So I'm moving this to the 8.x-3.x branch for consideration.

I'm still willing to consider this for D8/D9 Rules, but I'm not going to work on this myself. If you find this useful and want to see it in Rules or in a contributed module like D8RE, then what we need here is a patch for Rules 8.x-3.x along with some tests cases to prove these new features are working.

Postponing this issue until someone thinks it's worth spending time on.

TR’s picture

Issue tags: +Needs tests