Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in pager.test over to PSR-0.

CommentFileSizeAuthor
#13 1598594_13_pager_psr.patch1.89 KBaspilicious
#8 0001-Pager-PSR-0.patch1.93 KBcosmicdreams
#3 0001-Pager-PSR-0.patch1.88 KBcosmicdreams
#2 0001-commit-change-to-pager.test-for-PSR-0.patch1.93 KBcosmicdreams
#1 1598594_1_pager_psr.patch24.93 KBcosmicdreams
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
Status: Active » Needs review
FileSize
1598594_1_pager_psr.patch24.93 KB

First Try

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
FileSize
0001-commit-change-to-pager.test-for-PSR-0.patch1.93 KB

rerolled with name change for file and function to PagerTest as per aspillicious's request. Also using git format-path here.

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
FileSize
0001-Pager-PSR-0.patch1.88 KB

second try to do the additional cleanup AND create one file with the format-patch.

Status: Needs review » Needs work
Issue tags: -PSR-0

The last submitted patch, 0001-Pager-PSR-0.patch, failed testing.

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
Status: Needs work » Needs review

#3: 0001-Pager-PSR-0.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +PSR-0

The last submitted patch, 0001-Pager-PSR-0.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

add

use SimpleXMLElement;

on top of the file and everything will be green.

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
FileSize
0001-Pager-PSR-0.patch1.93 KB

Wow, did my first rebase -i. That was an educational experience. Anyway here's a new patch for the system to test.

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
Status: Needs work » Needs review
RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community

Well done!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Issue tags: -PSR-0

#8: 0001-Pager-PSR-0.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +PSR-0

The last submitted patch, 0001-Pager-PSR-0.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1598594_13_pager_psr.patch1.89 KB

Rerolled

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community

If we were smart, we'd coordinate these patches without needing a reroll for system.info all the time :-) .

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

From now on I'm going to just ignore system.info hunks if they don't apply (or if they're not there at all), and we can nuke those at the end all at once.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committe/pushed.

Automatically closed -- issue fixed for 2 weeks with no activity.