Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in bootstrap.test over to PSR-0.
Comment | File | Size | Author |
---|---|---|---|
#19 | 1598556-bootstrap-tests-psr-0-19.patch | 54.28 KB | Niklas Fiekas |
#14 | 1598556-bootstrap-tests-psr-0-14.patch | 54.31 KB | Niklas Fiekas |
#11 | 1598556-bootstrap-tests-psr-0-11.patch | 121.86 KB | Niklas Fiekas |
#11 | 1598556-bootstrap-tests-psr-0-11-interdiff.txt | 2.13 KB | Niklas Fiekas |
#9 | 1598556-bootstrap-tests-psr-0-9.patch | 54.25 KB | Niklas Fiekas |
Comments
Comment #1
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedDoing this now.
Comment #2
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedOk, all classes converted.
I have also attached the concatenated output of
git blame -C <new-file.php>
for all the new files (best viewed without the automatic line wrapping of Dreditor - open in a new tab and zoom out or something, to get an overview), showing that most of the code is directly and unchanged coming from the old test file.Comment #3
RobLoachThe IP Acronymn is camel-cased :-) .
Comment #4
aspilicious CreditAttribution: aspilicious commentedGetFilenameTest
BootstrapGetFilenameTest
Same thing, different name
In the other conversions I always had a "UnitTest" suffix. I would like to be consistent but I'm not going to fight for it.
4 days to next Drupal core point release.
Comment #5
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedFixed that. Also using the UnitTest suffix, now.
Comment #6
RobLoachCamel-case acronyms :-) .
Comment #7
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedHeh ... lol. Thanks!
Comment #8
aspilicious CreditAttribution: aspilicious commentedMismatch code vs doc classname
Mismatch code vs doc classname
3 days to next Drupal core point release.
use UnitTest as a suffix or don't, as we are doing it alrdy in this patch and else we should keep doing that.
3 days to next Drupal core point release.
Comment #9
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedThanks for reviewing!
Comment #10
aspilicious CreditAttribution: aspilicious commentedSrry missed a few unit tests while reviewing!
Found more unit tests
Another one
2 days to next Drupal core point release.
Comment #11
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedChanged that.
Comment #12
aspilicious CreditAttribution: aspilicious commented#11: 1598556-bootstrap-tests-psr-0-11.patch queued for re-testing.
Comment #14
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedMerged the changes from the kernel branch. (Yay, for that it's in!)
Comment #15
aspilicious CreditAttribution: aspilicious commentedGood to go
Comment #16
Dries CreditAttribution: Dries commented#14: 1598556-bootstrap-tests-psr-0-14.patch queued for re-testing.
Comment #17
Dries CreditAttribution: Dries commentedI think this patch needs a re-roll. Asking for a re-test.
Comment #19
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedRerolled.
Comment #20
aspilicious CreditAttribution: aspilicious commentedgreen again ;)
Comment #21
Dries CreditAttribution: Dries commentedGreat - glad things are back to green. Committed to 8.x. Thanks!