Convert bootstrap.test to PSR-0

Doing this now.

Ok, all classes converted.

I have also attached the concatenated output of git blame -C <new-file.php> for all the new files (best viewed without the automatic line wrapping of Dreditor - open in a new tab and zoom out or something, to get an overview), showing that most of the code is directly and unchanged coming from the old test file.

+++ b/core/modules/system/lib/Drupal/system/Tests/Bootstrap/GetFilenameTest.phpundefined
@@ -0,0 +1,55 @@
+ * Definition of Drupal\system\Tests\Bootstrap\GetFilenameTest.

GetFilenameTest

+++ b/core/modules/system/lib/Drupal/system/Tests/Bootstrap/GetFilenameTest.phpundefined
@@ -0,0 +1,55 @@
+class BootstrapGetFilenameTest extends UnitTestBase {

BootstrapGetFilenameTest

Same thing, different name

+++ b/core/modules/system/lib/Drupal/system/Tests/Bootstrap/ResettableStaticTest.phpundefined
@@ -0,0 +1,49 @@
+class ResettableStaticTest extends UnitTestBase {

In the other conversions I always had a "UnitTest" suffix. I would like to be consistent but I'm not going to fight for it.

4 days to next Drupal core point release.

Fixed that. Also using the UnitTest suffix, now.

Heh ... lol. Thanks!

+++ b/core/modules/system/lib/Drupal/system/Tests/Bootstrap/GetFilenameUnitTest.phpundefined
@@ -0,0 +1,55 @@
+ * Definition of Drupal\system\Tests\Bootstrap\GetFilenameTest.

+class GetFilenameUnitTest extends UnitTestBase {

Mismatch code vs doc classname

+++ b/core/modules/system/lib/Drupal/system/Tests/Bootstrap/ResettableStaticUnitTest.phpundefined
@@ -0,0 +1,49 @@
+ * Definition of Drupal\system\Tests\Bootstrap\ResettableStaticTest.
...
+class ResettableStaticUnitTest extends UnitTestBase {

Mismatch code vs doc classname

3 days to next Drupal core point release.

+++ b/core/modules/system/lib/Drupal/system/Tests/Bootstrap/TimerTest.phpundefined
@@ -0,0 +1,45 @@
+class TimerTest extends UnitTestBase {

use UnitTest as a suffix or don't, as we are doing it alrdy in this patch and else we should keep doing that.

3 days to next Drupal core point release.

Thanks for reviewing!

Srry missed a few unit tests while reviewing!

+++ b/core/modules/system/lib/Drupal/system/Tests/Bootstrap/MiscTest.phpundefined
@@ -1,461 +1,18 @@
+class MiscTest extends UnitTestBase {

Found more unit tests

+++ b/core/modules/system/lib/Drupal/system/Tests/Bootstrap/OverrideServerVariablesTest.phpundefined
@@ -2,32 +2,55 @@
+class OverrideServerVariablesTest extends UnitTestBase {

Another one

2 days to next Drupal core point release.

Changed that.

#11: 1598556-bootstrap-tests-psr-0-11.patch queued for re-testing.

Merged the changes from the kernel branch. (Yay, for that it's in!)

Good to go

#14: 1598556-bootstrap-tests-psr-0-14.patch queued for re-testing.

I think this patch needs a re-roll. Asking for a re-test.

Rerolled.

green again ;)

Great - glad things are back to green. Committed to 8.x. Thanks!