Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in batch.test over to PSR-0.
Comment | File | Size | Author |
---|---|---|---|
#21 | move-batch-tests.patch | 1.63 KB | aspilicious |
#16 | patchcharacters.png | 54.66 KB | jhodgdon |
#14 | 1598552_14_batch_psr.patch | 14.1 KB | cosmicdreams |
#9 | 1598552_9_batch_psr.patch | 72.66 KB | cosmicdreams |
#7 | 1598552_6_batch_psr.patch | 72.63 KB | cosmicdreams |
Comments
Comment #1
RobLoachComment #2
aspilicious CreditAttribution: aspilicious commentedTest file needs to be deleted from .info file
Comment #3
RobLoachComment #4
aspilicious CreditAttribution: aspilicious commentedI would change this to PercentageUnitTest but I don't care if someone else would rtbc this
3 days to next Drupal core point release.
Comment #5
aspilicious CreditAttribution: aspilicious commented#3: 1598552.patch queued for re-testing.
Comment #7
cosmicdreams CreditAttribution: cosmicdreams commentedRerolled and applied the name change from #4 because it made sense.
Comment #8
aspilicious CreditAttribution: aspilicious commentedForgot to change the name in the header
23 days to next Drupal core point release.
Comment #9
cosmicdreams CreditAttribution: cosmicdreams commentedAlso, I didn't change the name of the file.
I remembered about this last night as I was going to bed.
Comment #10
aspilicious CreditAttribution: aspilicious commentedgood!
Comment #11
jhodgdonUm. Take a look at this patch... it's all weird characters.... can't read it at all?
Comment #12
cosmicdreams CreditAttribution: cosmicdreams commentedjhodgdon: can you please look again http://drupal.org/files/1598552_9_batch_psr.patch
I don't see the weird characters you speak of.
Comment #13
aspilicious CreditAttribution: aspilicious commented? I'm not sure what jhogdon means but you forgot to remove the line from the info file.
Comment #14
cosmicdreams CreditAttribution: cosmicdreams commentedthis patch attempts to fix both issues:
Comment #15
cosmicdreams CreditAttribution: cosmicdreams commentedthe previous patch is much smaller because it attempts to move instead of copy the code from the existing file to the new file.
Comment #16
jhodgdonThis newer file is viewable, but when I look at the patch in #9, this is what I see. Weird.
Comment #17
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedSo that one had windows line endings, UCS character set and reverse byte order.
The newer patch is fine. (Character set. Didn't review it.)
Comment #18
aspilicious CreditAttribution: aspilicious commentedback to rtbc
Comment #19
catchThanks. Committed/pushed to 8.x.
Comment #20
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedLooks like these were accidantely moved to the wrong directory
core/modules/system/lib/system/Tests/Batch
, rather thancore/modules/system/lib/Drupal/system/Tests/Batch
. Bumping to major, because the tests are currently not executed.Comment #21
aspilicious CreditAttribution: aspilicious commentedComment #22
Niklas Fiekas CreditAttribution: Niklas Fiekas commentedExcellent, thanks. (Assuming tests pass. However could be not, because it's the first time they run with PSR-0.)
Comment #23
catchOops. Committed/pushed, thanks!
Comment #24
David_Rothstein CreditAttribution: David_Rothstein commentedSince that's pretty bad, I've written a patch at #1632364: Write tests to ensure that all classes in Drupal can actually be found by the autoloader that should help us catch these mistakes automatically in the future, rather than having to find them manually.