Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobLoach’s picture

Status: Active » Needs review
FileSize
13.7 KB
aspilicious’s picture

Status: Needs review » Needs work

Test file needs to be deleted from .info file

RobLoach’s picture

Status: Needs work » Needs review
FileSize
14.13 KB
aspilicious’s picture

+++ b/core/modules/system/lib/system/Tests/Batch/PercentagesTest.phpundefined
@@ -0,0 +1,104 @@
+class PercentagesTest extends UnitTestBase {

I would change this to PercentageUnitTest but I don't care if someone else would rtbc this

3 days to next Drupal core point release.

aspilicious’s picture

Issue tags: -PSR-0

#3: 1598552.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +PSR-0

The last submitted patch, 1598552.patch, failed testing.

cosmicdreams’s picture

Status: Needs work » Needs review
FileSize
72.63 KB

Rerolled and applied the name change from #4 because it made sense.

aspilicious’s picture

Status: Needs review » Needs work
+++ b/core/modules/system/lib/system/Tests/Batch/PercentagesTest.phpundefined
@@ -0,0 +1,104 @@
+ * Definition of Drupal\system\Tests\Batch\PercentagesTest.
...
+class PercentagesUnitTest extends UnitTestBase {

Forgot to change the name in the header

23 days to next Drupal core point release.

cosmicdreams’s picture

Status: Needs work » Needs review
FileSize
72.66 KB

Also, I didn't change the name of the file.

I remembered about this last night as I was going to bed.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

good!

jhodgdon’s picture

Status: Reviewed & tested by the community » Needs work

Um. Take a look at this patch... it's all weird characters.... can't read it at all?

cosmicdreams’s picture

jhodgdon: can you please look again http://drupal.org/files/1598552_9_batch_psr.patch

I don't see the weird characters you speak of.

aspilicious’s picture

? I'm not sure what jhogdon means but you forgot to remove the line from the info file.

cosmicdreams’s picture

Status: Needs work » Needs review
FileSize
14.1 KB

this patch attempts to fix both issues:

cosmicdreams’s picture

the previous patch is much smaller because it attempts to move instead of copy the code from the existing file to the new file.

jhodgdon’s picture

FileSize
54.66 KB

This newer file is viewable, but when I look at the patch in #9, this is what I see. Weird.

Niklas Fiekas’s picture

$ enca -L none 1598552_9_batch_psr.patch 
Universal character set 2 bytes; UCS-2; BMP
  CRLF line terminators
  Byte order reversed in pairs (1,2 -> 2,1)

So that one had windows line endings, UCS character set and reverse byte order.

$ enca -L none 1598552_14_batch_psr.patch 
7bit ASCII characters

The newer patch is fine. (Character set. Didn't review it.)

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

back to rtbc

catch’s picture

Status: Reviewed & tested by the community » Fixed

Thanks. Committed/pushed to 8.x.

Niklas Fiekas’s picture

Title: Convert batch.test to PSR-0 » Move batch tests to the right directory
Priority: Normal » Major
Status: Fixed » Needs work
Issue tags: +Novice

Looks like these were accidantely moved to the wrong directory core/modules/system/lib/system/Tests/Batch, rather than core/modules/system/lib/Drupal/system/Tests/Batch. Bumping to major, because the tests are currently not executed.

aspilicious’s picture

Status: Needs work » Needs review
FileSize
1.63 KB
Niklas Fiekas’s picture

Status: Needs review » Reviewed & tested by the community

Excellent, thanks. (Assuming tests pass. However could be not, because it's the first time they run with PSR-0.)

catch’s picture

Priority: Major » Normal
Status: Reviewed & tested by the community » Fixed

Oops. Committed/pushed, thanks!

David_Rothstein’s picture

Looks like these were accidantely moved to the wrong directory core/modules/system/lib/system/Tests/Batch, rather than core/modules/system/lib/Drupal/system/Tests/Batch. Bumping to major, because the tests are currently not executed.

Since that's pretty bad, I've written a patch at #1632364: Write tests to ensure that all classes in Drupal can actually be found by the autoloader that should help us catch these mistakes automatically in the future, rather than having to find them manually.

Automatically closed -- issue fixed for 2 weeks with no activity.