Menu items with such paths as my-page#tab3 get stripped out to just my-page
The ability exists in core menus.

Note: such items must be entered as node/555#tab3

CommentFileSizeAuthor
#2 megamenu-item-options-1597628-1.patch1.71 KBdoublejosh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

doublejosh’s picture

doublejosh CreditAttribution: doublejosh commented
Issue summary: View changes

add note.

doublejosh’s picture

doublejosh CreditAttribution: doublejosh commented

Seems I can't get to it from theme_menu_link()

doublejosh’s picture

doublejosh CreditAttribution: doublejosh commented
FileSize
megamenu-item-options-1597628-1.patch1.71 KB

There are plenty of lines in this module with no regard for attributes beyond href.

EXAMPLE LINE 223
'data'=>l($leaf['link']['link_title'], $leaf['link']['href'], $leaf['link']['options']),

By carrying in the options, I'm sure there are other features that will get taken advantage of too.
This is an easy win.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Active » Needs review

Thank you for the patch. This issue is related to:
#1463820: Adding title attribute to link
#1195348: megamenu omits link parameters
#1205068: Refactored theme_megamenu_menu_tree(), multiple fixes.

greggmarshall’s picture

greggmarshall
Location Aurora/Denver, Colorado
CreditAttribution: greggmarshall commented

Patch from #2 resolved the problem we were having using HTML bookmarks (aka in page links, fragments, hash links) not being rendered in our megamenus.

Thanks @doublejosh.

greggmarshall’s picture

greggmarshall
Location Aurora/Denver, Colorado
CreditAttribution: greggmarshall commented
Issue summary: View changes

note.

ram4nd’s picture

ram4nd CreditAttribution: ram4nd at Wunder commented
Issue summary: View changes
Status: Needs review » Fixed

Seems that this is already in the code.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.