Deploy already depends on the services module, so I think it would make sense to add support for controlling deploy via services. My initial targets for services support are:

* List plans
* Retrieve a plan
* Deploy a plan
* Create a plan
* Delete a plan

Later on I would like to be able to manage a plan via services, but for me right now that is a wish list item.

CommentFileSizeAuthor
#8 deploy-1592734-add-services-8.patch11.09 KBskwashd
#4 deploy-1592734-add-services-4.patch13.82 KBskwashd
#1 deploy-1592734-services_support.patch4.7 KBskwashd

Comments

skwashd’s picture

skwashd commented
StatusFileSize
new deploy-1592734-services_support.patch4.7 KB

Here is my first cut patch. I know it could do with some work, but I'm throwing it over the fence for some initial feedback.

The patch adds support for listing, retrieving and deploying plans. To make this work I needed to move the permissions from the deploy_ui module to deploy. Let me know what you think.

jherencia’s picture

jherencia commented

This looks great :).

skwashd’s picture

skwashd commented
Assigned: Unassigned » skwashd
Status: Needs work » Needs review

Working on a round of fixes and enhancements for this. I'd appreciate some more feedback on it.

skwashd’s picture

skwashd commented
StatusFileSize
new deploy-1592734-add-services-4.patch13.82 KB

This is my next attempt. I still need to add UUID support, but other than that I think I'm pretty close. Feedback welcome.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented

Looks really good to me. The patch was smaller than I though it would be :)
I will need to find some time testing it out. But I'm very positive in letting this in, without any major modifications.

dixon_’s picture

dixon_
he/him
Primary language English
Location France
commented

I talked to skwashd on IRC, and I was actually looking on the first patch when leaving the last comment. I have some problems with the second patch. I think we should just wrap the existing API (based on CTools plugins and export API) in a services resource. Very much like the first patch.

Making plans into entities introduces too many API changes and we'll lose (or have to rework) the export functionality based on the export functionality in Entity API module. That will also break already exported features.

So again, I think we'll be able to reach the same functionality without changing too many things, if we just wrap the exiting API in a services resource. Something like the approach in the first patch.

skwashd’s picture

skwashd commented

I'm happy enough to split the patch. but that only solves half the problem. I still need to be able to deploy the plans themselves - which means using entities.

skwashd’s picture

skwashd commented
Issue tags: +services
StatusFileSize
new deploy-1592734-add-services-8.patch11.09 KB

I discussed this with dixon on IRC last night. We are splitting the patch into 2 parts, this will remain focused on adding services support to deploy. The other patch will be a new sub module for making deployment plans themselves deployable.

I can commit this myself, but I'd appreciate another set of eyes going over it before I commit it.

manuel garcia’s picture

manuel garcia commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

This was already done.