Backreference in views breaks when referenced field used in multiple bundle types.

>> two different bundle types yields "extra" fields not referenced by the originating node.

That was "extra rows" not "extra fields"

I"m opening this back up. Pretty sure this is a bug and not how a backreferences should work. Here's the gist of it:

When the base of a view is an entity of type "node" creating a Reverse reference in Views, i.e. something that reads like "Relationship "Content: Stores(s) (field_store) - reverse (to Content)" should return "content", i.e. nodes. It should not return "Users".

As currently constructed query blindly assumes that all entity_ids are NIDs. If the entity_type is type "user" entity id is a UID not a NID. If there is a Node where NID = uid-returned-from-view you'll get "extra" mis-related rows returned.

I'm now thinking that it's not the BUNDLE type, that's the issue, but the ENTITY type. The entity type should be specified as a condition in the join:

LEFT JOIN field_data_field_hotel field_data_field_store ON node.nid = field_data_field_store.field_store_nid
AND field_data_field_store.entity_type = 'node'

While I'm by no means an expert on the dark inner workings of these entity tables it would seem to me that one way to fix this programatically would be to make this be field_data_field_store.entity_type = entity-type-of- views-base-table. This would make the backreference work in the great majority of cases. It seems that a "multiple entity back reference" would require some tricky joins and might best be handled separately.

And another thing... This is probably another issue, but it looks like the view as constructed will also pick up deleted field references. After removing the field_store field from my user table in the above example, there are still rows in field_data_field_store with entity_type "user" left in field_data_field_store with the deleted column set to 1. While we're at it we should probably filter them out in the join as well:

LEFT JOIN field_data_field_hotel field_data_field_storeON node.nid = field_data_field_store.field_store_nid
AND field_data_field_store.entity_type = 'node'  AND field_data_field_store.deleted <> 1

Regarding #2 above:
I think you're mis-reading the query. It's created by Views and performs the joins correctly, it just isn't limiting the joins for multiple entity use cases.

Based on implementations of hook_field_views_data_views_data_alter() found in the views module ( see views/modules/taxonomy.views.inc, etc) I think the solution here is pretty straightforward: add a 'join_extra' array to $data['node'][$pseudo_field_name]['relationship'] in node_reference_field_views_data_views_data_alter() as below.

This seems to work:

    $data['node'][$pseudo_field_name]['relationship'] = array(
      'title' => $title,
      'help' => t('Relate each @entity referencing the node through @field.', array('@entity' => $entity, '@field' => $label)),
      'handler' => 'views_handler_relationship_entity_reverse',
      'field_name' => $field['field_name'],
      'field table' => _field_sql_storage_tablename($field),
      'field field' => $field['field_name'] . '_nid',
      'base' => $entity_info['base table'],
      'base field' => $entity_info['entity keys']['id'],
      'label' => t('!field_name', array('!field_name' => $field['field_name'])),
      'join_extra' => array(
        0 => array(
          'field' => 'entity_type',
          'value' => $entity_type,
        ),
        1 => array(
          'field' => 'deleted',
          'value' => 0,
          'numeric' => TRUE,
        ),
      ),      
    );

Will post a patch shortly.

Patch for #6

Hmm, looks like patches created by TortoiseGit aren't liked. Let's try this again.

#9: node_reference.patch queued for re-testing.

3rd time's a charm, I hope.