Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After seeing #1230210: Add support for location.module I have created patch for getlocations_fields module.
Comment | File | Size | Author |
---|---|---|---|
#6 | add-getlocations_fields-module-support_6.patch | 1.39 KB | hutch |
add-getlocations_fields-module-support.patch | 1.05 KB | jibran | |
Comments
Comment #1
hutch CreditAttribution: hutch commentedI cloned staticmaps on 7.x-1.x, applied the patch, copied it all over to a test site with getlocations and getlocations_fields running, configured it, selected it under 'Manage Display' on a getlocations_fields enabled content type and the map appeared.
So it works.
Comment #1.0
jibranUpdated issue summary.
Comment #2
podarokbot trigger
Comment #3
podarokthis patch doesn't apply
Comment #4
podarokplease, add @files and class comments.
please, add docblock for method
Comment #6
hutch CreditAttribution: hutch commentedHere is a patch on a fresh pull of dev, with typo corrections etc, tested on current getlocations_fields.
Comment #7
jibranHi @hutch how are you? Thanks for the patch update. @podarok thanks for looking into it. Do we need some kind of tests here or is it fine as is?
Comment #8
hutch CreditAttribution: hutch commentedThe patch has passed the simpletest stuff, that's nice, it would be good for others to test this by applying the patch to a fresh pull of dev of staticmap module and editing the "manage display" settings of a content type with a getlocations_fields instance in it. It works for me.
Comment #9
jibranWorks for me as well thanks @hutch. @podarok could we please add getlocations_fields module to the project page as well after the commit? Thanks.
Comment #10
hutch CreditAttribution: hutch commentedI will add a link to staticmap on the Getlocations project page when this patch is commited.
Comment #12
podarokThanks to all
Commited
Will do tag in a next release.