After seeing #1230210: Add support for location.module I have created patch for getlocations_fields module.

CommentFileSizeAuthor
#6 add-getlocations_fields-module-support_6.patch1.39 KBhutch
add-getlocations_fields-module-support.patch1.05 KBjibran

Comments

hutch’s picture

hutch commented
Title: Add support for getlocations_fileds module » Add support for getlocations_fields module

I cloned staticmaps on 7.x-1.x, applied the patch, copied it all over to a test site with getlocations and getlocations_fields running, configured it, selected it under 'Manage Display' on a getlocations_fields enabled content type and the map appeared.
So it works.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue summary: View changes

Updated issue summary.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Issue summary: View changes
Status: Needs review » Active

bot trigger

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Active » Needs review

this patch doesn't apply

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Needs work 
  1. +++ b/includes/mapFieldGetlocations.php
@@ -0,0 +1,12 @@
+class mapFieldGetlocations extends mapFieldBase {

    please, add @files and class comments. 

  2. +++ b/includes/mapFieldGetlocations.php
@@ -0,0 +1,12 @@
+  public function provide_geodata(&$items) {

    please, add docblock for method

The last submitted patch, add-getlocations_fields-module-support.patch, failed testing.

hutch’s picture

hutch commented
StatusFileSize
new add-getlocations_fields-module-support_6.patch1.39 KB

Here is a patch on a fresh pull of dev, with typo corrections etc, tested on current getlocations_fields.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review

Hi @hutch how are you? Thanks for the patch update. @podarok thanks for looking into it. Do we need some kind of tests here or is it fine as is?

hutch’s picture

hutch commented

The patch has passed the simpletest stuff, that's nice, it would be good for others to test this by applying the patch to a fresh pull of dev of staticmap module and editing the "manage display" settings of a content type with a getlocations_fields instance in it. It works for me.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Works for me as well thanks @hutch. @podarok could we please add getlocations_fields module to the project page as well after the commit? Thanks.

hutch’s picture

hutch commented

I will add a link to staticmap on the Getlocations project page when this patch is commited.

  • podarok committed 691c3e3 on 7.x-1.x authored by hutch 
    Issue #1564394 by jibran, hutch: Add support for getlocations_fields...
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Reviewed & tested by the community » Fixed

Thanks to all
Commited
Will do tag in a next release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.