This is a simple patch for supporting the resp_img module. Please review...
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | flexslider_resp_img.patch | 1.09 KB | muschpusch |
| #2 | flexslider_resp_img.patch | 1.05 KB | muschpusch |
| flexslider_resp_img.patch | 1.06 KB | muschpusch |
This is a simple patch for supporting the resp_img module. Please review...
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | flexslider_resp_img.patch | 1.09 KB | muschpusch |
| #2 | flexslider_resp_img.patch | 1.05 KB | muschpusch |
| flexslider_resp_img.patch | 1.06 KB | muschpusch |
Comments
Comment #1
attiks commentedtrailing white space
trailing white space
Comment #2
muschpusch commentedfixed
Comment #3
attiks commentedsomething wrong with the patch:
git apply -v flexslider_resp_img_0.patch
fatal: corrupt patch at line 28
Comment #4
muschpusch commentedok lazy editing the patch file wasn't good enough. One more rerolled....
Comment #5
attiks commentedI will try to test this later today, but ...
white space?
Comment #6
askibinski commentedIs the patch really necessary for resp_img support?
I have flexslider and resp_image configured without the patch and it seems to work just fine.
If I'm wrong, could you explain what the benefit would be?
Comment #7
attiks commented@askibinski Did you applied #1512636: Add caption support to Views style plugin, because then it probably will just work without this patch
Comment #8
askibinski commented@attiks ah yes, I did apply that patch, thanks.
Comment #9
attiks commentedMarking this as a duplicate in favor of #1512636: Add caption support to Views style plugin