Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.While I have been reviewing code thinking in documentation improvements, I end up looking into other issues, like #1528688: Rework item history retrieval. And indeed, item entity really needs some attention.
Here I am attaching a patch that covers mainly documentation changes on the item interfaces and its example implementations on versioncontrol_fakevcs module. It also change method names, but it does not solve #606678: remove verbs from interfaces yet.
So, in the middle of this process, and after discussing the idea with Howard(tizzo), it seems like the best idea is to make item optional features pluggable, so we do not depend on a single backend implementation(i.e. on vc_git some people would like to access git with libgit2, phpgit, etc), beacuse some of these optional features need access to the repository.
| Comment | File | Size | Author |
|---|---|---|---|
| 0001-Pseudo-standarize-internally-optional-item-iterfaces.patch | 34.09 KB | marvil07 |
Comments
Comment #1
marvil07 commentedAfter along discussion with Howard and Sam about the several versioncontrol features, including optional item features, we decided that we should remove all the optional item features, since they do not seems like really needed now(no backend is using them).
That ended up in removing all item optional features, but they are there in history, so we could(and we will at least some of them) recover it in the future.
BTW the idea of make optional item features pluggable made sense for all, so when moving each of them back we would probably try to use ctools plugins for them.
Comment #2
marvil07 commentedtagging