Image not found when using img src=//www.something.com/image.jpg [#1542056]

If HTML code contains images with src attribute starting with two slashes (without protocol part), PDF version does not include this image.

Example HTML code:

<img id="chart-chart_field_chart_collection" class="chart" src="//chart.googleapis.com/chart?chd=t%3A2001%2C2002%2C2003%7C14423.00%2C13211.00%2C16732.00&amp;cht=p3&amp;chs=300x150&amp;chf=" alt="Chart">

This image won't be visible in PDF - you will get errors instead:

Image not found
http://my.domain.com/chart.googleapis.com/chart?chd=t%3A2001%2C2002%2C20...

where my.domain.com is my domain name.

I've tried to fix it - the patch that makes it working is attached below.

Comment	File	Size	Author
#1	print-replace_img_src_urls_with_absolute_urls-1542056-1.patch	2.47 KB	lklimek
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

lklimek CreditAttribution: lklimek commented 22 April 2012 at 00:20

File	Size
print-replace_img_src_urls_with_absolute_urls-1542056-1.patch	2.47 KB

Patch is attached.

Tested only with "book" content type.

Comment #2

lklimek CreditAttribution: lklimek commented 22 April 2012 at 00:24

Category:

task

» bug

Comment #3

jcnventura CreditAttribution: jcnventura commented 10 May 2012 at 16:11

Status:

Active

» Needs review

I can't understand why you need to call the image replacement explicitly.. The PDF module already does this to all images, and the others shouldn't care... Have you tested with only the modifications you did to _print_rewrite_urls() ?

Comment #4

modstore CreditAttribution: modstore commented 13 May 2012 at 23:13

Because the only call the the _print_rewrite_urls() function is with a pattern to match a href's, it is necessary to call with a pattern matching img's as well.