Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When a videoJS-enabled node is added to a panel, the panels cogs disappear for users in IE8.
This may be a conflict with admin module, as the JS error seems to be in jquery.drilldown.js
I haven't had time to investigate too far - the attached patch fixes it, but seems a bit hacky to me...
Comment | File | Size | Author |
---|---|---|---|
#3 | with admin enabled | 202.27 KB | malcomio |
#3 | admin disabled - works fine | 185.46 KB | malcomio |
videojs_panelcontent.patch | 476 bytes | malcomio | |
Comments
Comment #1
Jorrit CreditAttribution: Jorrit commentedCan you post a screenshot of the javascript error and the page on which the error occurs?
Comment #2
Jorrit CreditAttribution: Jorrit commentedI can't reproduce this.
Comment #3
malcomio CreditAttribution: malcomio commentedI've just done some testing on a very basic environment, in the stark theme, and it is definitely a conflict with the admin module - with that module disabled there's no problem.
The IE debugger error is:
Comment #4
Jorrit CreditAttribution: Jorrit commentedIt looks like that site is a test site. Can I get administrator access to investigate the problem?
Comment #5
malcomio CreditAttribution: malcomio commentedyes thanks - i'll send you a direct message with the details
Comment #6
Jorrit CreditAttribution: Jorrit commentedFirst of all, I don't understand why you post this issue for the Video.js module. This is not a bug or incompatibility between Video.js and any other module. It is actually a bug in the Admin module, which has already been reported in #969916: jquery.drilldown.js Breadcrumb error. You can try the patches there. The Admin module has not seen a new release in 1.5 years, perhaps you should try a module that is maintained better.
If I am wrong and this actually is a Video.js bug, please let me know. The source of the problem that I found is that in
jquery.drilldown.js
there is afor
loop over all properties of a project, but it does not exclude standard properties likeindexOf
. IE8 fails on that.Comment #7
malcomio CreditAttribution: malcomio commentedThanks for your help - I hadn't found that issue, and admin had been working fine until we came across panel pages with videos in, so I'd assumed the problem was likely to be at the video end.
I'll try the patches from that issue if I get time - in the short term my patch above sidesteps the problem.