Work in progress toward Drupal 8 Port.

Not complete by any means (not all tests pass, for instance). But I'm using it, and wanted to make sure my efforts to get it working weren't lost.

CommentFileSizeAuthor
7.x-1.x...8.x-1.x.patch.txt5.24 KBlotyrin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

lotyrin’s picture

lotyrin CreditAttribution: lotyrin commented

This now has a sandbox, per request by xjm: http://drupal.org/sandbox/lotyrin/1539824

stella’s picture

stella CreditAttribution: stella commented

Excellent!! Thank you!

infiniteluke’s picture

infiniteluke CreditAttribution: infiniteluke commented

If anyone isn't sure how to apply these patches, remove the email headers and break out the individual patches into separate files.

For example: 

From cc6ecd8446dd71572b1c4bb9678a020d44e847dd Mon Sep 17 00:00:00 2001
From: Gregory Perry <lotyrin@gmail.com>
Date: Mon, 16 Apr 2012 23:40:58 +0000
Subject: [PATCH 4/4] Fix use of theme_image

---
 coder_review/coder_review.module |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/coder_review/coder_review.module b/coder_review/coder_review.module
index b1d62a2..feeba1f 100644
--- a/coder_review/coder_review.module
+++ b/coder_review/coder_review.module
@@ -2207,13 +2207,13 @@ function theme_coder_review_warning($variables) {
   $path = drupal_get_path('module', 'coder');
   $title = t('severity: @severity', array('@severity' => $severity_name));
   $img = theme('image', array(
-    'path' => $path . "/images/$severity_name.png",
+    'uri' => $path . "/images/$severity_name.png",
     'alt' => $title, 'title' => $title,
     'attributes' => array('align' => 'right', 'class' => 'coder'),
     'getsize' => FALSE,
   ));
   if (!empty($description)) {
-    $img .= theme('image', array('path' => $path . '/images/more.png', 'alt' => t('click to read more'), 'atributes' => array('align' => 'right', 'class' => 'coder-more'), 'getsize' => FALSE));
+    $img .= theme('image', array('uri' => $path . '/images/more.png', 'alt' => t('click to read more'), 'atributes' => array('align' => 'right', 'class' => 'coder-more'), 'getsize' => FALSE));
     $warning .= '<div class="coder-description">Explanation: ' . $description . '</div>';
   }
   return '<div class="' . $class . '">' . $img . $warning . '</div>';
-- 
1.7.5.4

becomes...

diff --git a/coder_review/coder_review.module b/coder_review/coder_review.module
index b1d62a2..feeba1f 100644
--- a/coder_review/coder_review.module
+++ b/coder_review/coder_review.module
@@ -2207,13 +2207,13 @@ function theme_coder_review_warning($variables) {
   $path = drupal_get_path('module', 'coder');
   $title = t('severity: @severity', array('@severity' => $severity_name));
   $img = theme('image', array(
-    'path' => $path . "/images/$severity_name.png",
+    'uri' => $path . "/images/$severity_name.png",
     'alt' => $title, 'title' => $title,
     'attributes' => array('align' => 'right', 'class' => 'coder'),
     'getsize' => FALSE,
   ));
   if (!empty($description)) {
-    $img .= theme('image', array('path' => $path . '/images/more.png', 'alt' => t('click to read more'), 'atributes' => array('align' => 'right', 'class' => 'coder-more'), 'getsize' => FALSE));
+    $img .= theme('image', array('uri' => $path . '/images/more.png', 'alt' => t('click to read more'), 'atributes' => array('align' => 'right', 'class' => 'coder-more'), 'getsize' => FALSE));
     $warning .= '<div class="coder-description">Explanation: ' . $description . '</div>';
   }
   return '<div class="' . $class . '">' . $img . $warning . '</div>';
lotyrin’s picture

lotyrin CreditAttribution: lotyrin commented

RE: #3

It's quite a bit simpler than that, use git rather than patch (git apply filename).

Also, if you don't have git and can't get it, simply splitting the several commits into seperate files should also resolve the issue. (Patch should ignore the headers on its own.)

infiniteluke’s picture

infiniteluke CreditAttribution: infiniteluke commented

Strange. I was running git apply -v filename on it and it wasn't working for me. Probably operator error ;)

TravisCarden’s picture

TravisCarden CreditAttribution: TravisCarden commented

Marked #1161796: Initial d8 port of Coder and Coder Review modules. as a duplicate of this issue.

pillarsdotnet’s picture

pillarsdotnet CreditAttribution: pillarsdotnet commented

So should I follow this issue or the sandbox?

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented
Issue tags: +D8 upgrade path, +D8, +8x upgrade

Tagging.

douggreen’s picture

douggreen CreditAttribution: douggreen commented
Status: Needs work » Closed (duplicate)

Thanks for taking this initiative. But this is now out of date because of the #1745068: Coder Review Drupal 8.x Battleplan. I will likely have an official port by Oct 1, as soon as the latest version gets enough usage that we feel good about it and as we can come to consensus on #1774268: Merging drupalcs into coder and #1772676: How to "ignore" warnings