Make taxonomy module pass Coder Review

Postponed because of #1326644: Clean up API docs for taxonomy module

No activity since past one month, so I'll start working on it.

Fixed most of the issues. Issues that remain are mostly related to documentation - either missing doc block or too long descriptions which can be solved as part of another issue IMO. Also, some other issues remain which can left as it is.

Changing protected function setUp() to public function setUp().

Drupal\taxonomy\TermTranslationHandler::entityFormSave() must be public. It was protected in last patch. Also making title() function public.

Reviewed, it looks good to me.

My attempt at re-rolling the patch.

I change the status to Needs review to wake up our test bot to test this patch ;)

Thanks lauriii.

re-created the patch using git commands.

Looks great and it's green!

The patch doesn't apply anymore

Currently rerolling it

Corrected tags.

Here is the new patch. Not sure about classes visibility.

Oops, forgot some conflicts.

@StephaneQ Please add an interdiff to you patch: https://www.drupal.org/documentation/git/interdiff/ That will help others to review the part that you have contributed.

Fixed the PHP error. I didn't manage to do the interdiff (maybe because the previous patch is too old?)

Thanks for all the work here so far. See #1518116-86: [meta] Make Core pass Coder Review. This issue is postponed until the meta issue is either closed or reopened.

Closing in favor of #2571965: [meta] Fix PHP coding standards in core, stage 1. In this issue the coding standards will be fixed on a sniff-per-sniff basis rather than a module-per-module basis.