Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Apr 2012 at 07:52 UTC
Updated:
29 Jul 2014 at 20:33 UTC
Following-up from #1320648: Meta: start converting existing core classes to PSR-0 [policy, no patch] and as agreed in #1290658: Move all module-provided classes to PHP namespaces (PSR-0 or similar), and autoload them without the registry [policy, no patch], we can now start converting module-provided classes to the PSR-0 standard.
Once we're through, #1541674: Remove the registry should pass.
Comments
Comment #0.0
berdirUpdated issue summary.
Comment #0.1
berdirUpdated issue summary.
Comment #0.2
berdirUpdated issue summary.
Comment #1
berdirAdd comment and taxonomy issues here as well.
We missed PagerDefault and TableSort so far which live in /includes but are always included. To keep track of them, maybe add them to this issue as well even though this is about modules? Or create a meta-meta "move everything to PSR-0/kill the registry" issue and add them directly there?
Other than than, I think there aren't many classes left except of the tests of course (and the base test classes in Simpletest itself). But I think it makes sense to wait with them until we have support for PSR-0 test classes and a first one commited, which is hopefully happening soon in the tracker issue. Then we can either create a number of issues or maybe even try to script it, as it should in theory be very simple to do and then we could do it in a single patch. It's going to break every patch in the issue that does something with tests anyway. Maybe combine it with the t() removal so that there is only a single time where we break everything?
Comment #2
catchI'm happy to try to schedule patches like moving tests around / removing t() from assertions etc.
Comment #2.0
catchAdd comment and taxonomy issues
Comment #2.1
berdirUpdated issue summary.
Comment #3
berdirThose field.module files contain some exception classes, opened #1542682: Convert exception classes in field.module to PSR-0. The other files are covered by the existing issues.
Comment #3.0
berdirUpdated issue summary.
Comment #3.1
berdirUpdated issue summary.
Comment #4
berdirFound another exception in includes/update.inc, opened #1545068: Convert Exception in update.inc to PSR-0.
Comment #4.0
berdirUpdated issue summary.
Comment #4.1
berdirUpdated issue summary.
Comment #4.2
aspilicious commentedAdded issue
Comment #4.3
aspilicious commentedAdded aggregator tests
Comment #4.4
aspilicious commentedAdded block tests
Comment #4.5
aspilicious commentedAdded book tests
Comment #4.6
aspilicious commentedAdded color tests
Comment #4.7
Tor Arne Thune commentedUpdated issue summary.
Comment #4.8
aspilicious commentedAdded couple more test issues
Comment #4.9
aspilicious commentedAdded dblog tests
Comment #4.10
aspilicious commentedAddded entity tests
Comment #4.11
aspilicious commentedfixed link
Comment #4.12
aspilicious commentedAdded 5 more test issues
Comment #4.13
aspilicious commentedAdded field tests
Comment #4.14
aspilicious commentedAdded locale, language and menu tests
Comment #4.15
aspilicious commentedAdded node and openid tests
Comment #4.16
aspilicious commentedAdded path tests
Comment #4.17
aspilicious commentedAdded poll and php tests
Comment #4.18
aspilicious commentedAdded rdf tests
Comment #4.19
aspilicious commentedAdded lots of test issues
Comment #4.20
aspilicious commentedAdded search
Comment #4.21
aspilicious commentedAdded system tests
Comment #4.22
aspilicious commentedAdded a field entity controller issue
Comment #4.23
aspilicious commentedAdded shortcut
Comment #5
aspilicious commentedWe have issues for everything now, lets review and patch!
Comment #5.0
aspilicious commentedAdded profiiles test issue
Comment #5.1
aspilicious commentedUpdate
Comment #5.2
aspilicious commentedAdded statistics
Comment #5.3
berdirUpdated issue summary.
Comment #5.4
aspilicious commentedSplitted done and todo issues
Comment #5.5
aspilicious commentedForgot tablesort
Comment #5.6
aspilicious commentedtwo done!
Comment #5.7
aspilicious commentedProfile is done
Comment #5.8
aspilicious commentedConfig fixed
Comment #5.9
aspilicious commentedSome more issues done
Comment #5.10
aspilicious commentedMoved tablesort
Comment #5.11
aspilicious commentedAdded issue
Comment #5.12
aspilicious commentedUpdated summary
Comment #5.13
aspilicious commentedUpdate
Comment #6
berdirOk, I'm marking this as fixed, the only remaining part is #1592632: Merge List field types into Options module which is already a major task on it's own.
Thanks everyone who worked on this!
I'm als going to set the remove registry issue to major and mark it postponed on the list issue and probably also until views/ctools/... is ready for PSR-0 (how far is that process?), so that it's not included in the threshold.
Comment #7.0
(not verified) commentedAll tasks done.