While the documentation page does mention that the form time limit is in seconds, the configuration form (admin/config/content/honeypot) doesn't make any reference to the unit of time. This patch updates the help text to mention that the form field is in seconds.

CommentFileSizeAuthor
#3 honeypot-form-time-suffix-1502850-3.patch393 bytesyannickoo
0001-honeypot-Clarify-the-unit-time-of-the-time-limit.patch1.38 KBchaseontheweb

Comments

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Active » Reviewed & tested by the community

The patch looks good maerleythedog, thanks. In future you should name the patches like it says in the documentation for creating patches:

git diff > [project_name]-[short-description]-[issue-number]-[comment-number].patch

To know the issue number you should first create your issue and immediately after that you can add a comment with the patch attached.

loominade’s picture

loominade commented
Status: Needs review » Reviewed & tested by the community

wouldn't it be better to use '#suffix' => t('seconds') instead?

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new honeypot-form-time-suffix-1502850-3.patch393 bytes

Nice idea loominade but we should consider which idea is better. Even patch with seconds suffix is attached.

geerlingguy’s picture

geerlingguy commented
Version: 7.x-1.11 » 7.x-1.x-dev

Probably going to go the route of using #suffix; thanks for the patches and reviews! I'll try to commit this soon, when I get back to my laptop.

geerlingguy’s picture

geerlingguy commented
Status: Reviewed & tested by the community » Fixed

Committed: http://drupalcode.org/project/honeypot.git/commit/3262839 - makes things a bit nicer!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.