The function view_unpublished_list_permissions() has not much value outside the scope of view_unpublished_permission(), so it would be better to factor it in.

The function name is also misleading, a developer that is looking for the full list of permissions that is provided by the module should call view_unpublished_permission(), not view_unpublished_list_permissions() since this does not even return the full list of permissions: 'view any published content' is missing from this list.

The function is also not documented.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfrenssen’s picture

Status: Active » Needs review
FileSize
1.29 KB
entendu’s picture

Status: Needs review » Closed (fixed)

Agreed, and I also prefer $array[] syntax to +=. Committed.