Closed (fixed)
Project:
Chaos Tool Suite (ctools)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Mar 2012 at 09:20 UTC
Updated:
4 Sep 2012 at 04:01 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
merlinofchaos commentedThis may be fixed in -dev. Can you please try and see?
Comment #2
sandergo90 commentedHaving the same problem. Tried updating to dev branch but no success still the error message.
Comment #3
Ashlar commentedIn order to assist you we need additional information. Please review the drupal.org/node/571990 'Submission Checklist' for the type of information we are looking for. If we cannot duplicate your problem we cannot fix it, so tell us the steps necessary to recreate the problem. When you post information, please change the status back to active. Thanks.
Comment #4
mneuhaus commentedThe main issue seems to be that $attributes['class'] is now an array instead of a string.
I've attached a patch to fix this.
Comment #5
rogical commentedNotice: Array to string conversion in page_manager_render_operations() (line 1211 of /opt/development/yourhelps/sites/all/modules/ctools/page_manager/page_manager.admin.inc).
...
git apply -v page_manager.admin_.diff
Checking patch (clipboard) ...
error: (clipboard) : No such file or directory
I solved this error by apply this patch manually.
Comment #6
rogical commentedComment #7
audster commentedI was getting this error on page creation, used above fix, error gone!
Thanks!
ctools 7.x-1.0
Comment #8
rellimevad commentedPatch in #4 worked here as well. PHP 5.4.2 and ctools 7.x-1.0.
Comment #9
tim.plunkettTheoretically, the class part of attributes should ALWAYS be an array.
But in any case, I think we'd be better off using drupal_attributes() here.
Comment #10
Anonymous (not verified) commentedPath for fix using drupal_attributes() as noted on #9
Comment #11
rogical commentedgit apply -v issue-1492274.patch
fatal: corrupt patch at line 14
Can't apply patch on 7.x-1.0
Comment #12
Anonymous (not verified) commentedI dont why it says it is corrupt. Please look at the code on the diff and make the changes manually?
May be if you post a similar patch, it will not be corrupted?
Thanks!
Comment #13
pfrenssenPatch in #10 fixes the problem, but indeed does not apply cleanly.
I rerolled the patch from #10 against the latest 7.x-1.x, this one should apply properly.
Comment #14
fishfree commentedThe patch works! Thank pfrenssen!
Comment #15
Letharion commentedThe patch in #13 misuses drupal_attributes and creates nonsensical class names like "0=>operations".
Comment #16
deepbluesolutions commentedI confirm the notice disappears after applying patch in #13. Dont understand the issue raised by #15, and have yet to see any other side effects, so far...
Comment #17
pfrenssenI cannot replicate the exact problem from #15 but I can see where it goes wrong. I rerolled the patch from #10 without really looking at the code, my apologies. I will create a better patch.
Comment #18
pfrenssenHehe it seems like someone has been looking at this before, I found this leftover debug code in the function:
Comment #19
pfrenssenThis should work a bit better. Mind that I wrote this blindly, I'm not using Page Manager and don't know how to replicate this problem. I just did the reroll a few weeks ago when I was quickly evaluating Page Manager for a project.
I tried to cover both the case that $attributes['class'] is supplied correctly as an array, and that it is not - in which case it disregards it.
Comment #20
pfrenssenI value the opinion of the test bot.
Comment #21
wOOge commentedJust tried the Dev from Aug 3 2012, and still getting these errors.
Comment #22
pfrenssen@wOOge, that's normal since this issue has not yet been resolved, so it is not available in dev yet. Only issues that are marked as "Fixed" are. Maybe if you have some time you can try if the patch in #19 solves the problem for you?
Comment #23
merlinofchaos commentedCommitted #19 to D7.
Comment #24
tim.plunketthttp://drupalcode.org/project/ctools.git/commit/116c49efd08ceecdb1acf3c6...
Comment #25
wOOge commented@pfrenssen — oops my bad. The latest release 7.x-1.1, Aug 9, does solve the problem. Thank you!!
Comment #26
mamanerd commentedPatch from #19 works for me, thanks @pfrenssen!