Making the CSS and icons included with ELF optional would make the module a bit more versatile. While it's easy to override the CSS from within a custom theme it could be interesting to have the CSS disabled from the start. This is especially true in a multisite environment with multiple themes.

Patch adding this functionality will follow.

CommentFileSizeAuthor
#1 make-icons-optional-1489876-1.patch832 bytesklaasvw

Comments

klaasvw’s picture

klaasvw commented
Status: Active » Needs review
StatusFileSize
new make-icons-optional-1489876-1.patch832 bytes

This tiny patch adds a configuration option to the global ELF admin form for excluding the css file. It defaults to including the css so it stays backwards compatible.

WorldFallz’s picture

WorldFallz commented
Issue summary: View changes
Status: Needs review » Postponed (maintainer needs more info)

Since the entire point of this module is to add the icons, can you explain this proposed feature a bit more? What's the point of using the module if you don't want the icons?

WorldFallz’s picture

WorldFallz commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Thought about this some more-- you can also turn 'off' the icons with css. So I'm not inclined to add this.

klaasvw’s picture

klaasvw commented
Status: Closed (won't fix) » Needs review

There may be some cases where simply a class is wanted, e.g. for giving the links a different color or using a custom icon provided by a theme.

WorldFallz’s picture

WorldFallz commented

which can all be done via css... what am i missing?

klaasvw’s picture

klaasvw commented

It saves you from overriding some css (in this case the background image). I know it's just a small thing so feel free to ignore if you don't want to introduce another variable.

WorldFallz’s picture

WorldFallz commented
Status: Needs review » Closed (won't fix)

it's also relatively minor to add a variable, but given that it's easily overridden as is, I think opting not to add additional php and a variable is probably the 'right' answer. thanks for the patch/suggestion though!