Job workflow is currently disabled and won't enable [#148474]

When I get to the Job workflow portion of the install (http://www.singularo.com/4_workflow_modules) it will not enable and gives no error

Comment	File	Size	Author
#3	erp_job.module_1.patch	2.28 KB	oadaeh
#2	erp_job.module_0.patch	3.32 KB	oadaeh

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

oadaeh CreditAttribution: oadaeh commented 8 June 2007 at 17:01

I'm seeing this behavior also. I've attempted to debug it, but as far as I got was determining that $op never gets set, so no actions happen.

I did also find a bug with the how often to process select field that I'll include in the patch I create.

Comment #2

oadaeh CreditAttribution: oadaeh commented 9 June 2007 at 00:37

Status:

Active

» Needs review

File	Size
erp_job.module_0.patch	3.32 KB

Well, the problem is that the $op variable isn't getting set, and that's because the $form_values[] array isn't filled at the point it's needed. Changing

$op = $form_values['op'];

$op = $_POST['op'];

gets it working. The better fix would be to create a submit function and do that processing there.

For the short term, I've attached a patch which uses $_POST. It also has fixes for four other problems that I discovered while trying to fix this one.

Comment #3

oadaeh CreditAttribution: oadaeh commented 9 June 2007 at 00:41

File	Size
erp_job.module_1.patch	2.28 KB

Oops! The previous patch has other changes that were submitted on other patches. This one has only the changes I mentioned.

Comment #4

singularo

Adelaide, AUS

CreditAttribution: singularo commented 15 June 2007 at 13:38

We're working on getting erp ready for 5.x at the moment. The $form_values vs $_POST['op'] things should be worked out with the remaining changes. No point in patching it back to $_POST['op'], as thats the "old way" of doing things.

Comment #5

oadaeh CreditAttribution: oadaeh commented 16 June 2007 at 22:36

I'm glad you're working on getting ready for 5.x, and I can't wait for it's completion. In the mean time, I and others want to review and try out this set of modules to see if they're suitable for our needs. My patch simply gives tdohner (and anyone else) an opportunity to do that. I did say "For the short term,".

Also, I and others can help out with small bugs and inconsistencies, so you all can focus on the main functionality of the module set. That won't be taking anything away from what you're doing, but will hopefully be helping you reach completion sooner.