Closed (fixed)
Project:
Translation Management Tool
Version:
7.x-1.x-dev
Component:
Translator: Nativy
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
14 Mar 2012 at 23:06 UTC
Updated:
5 Jun 2012 at 06:01 UTC
Jump to comment: Most recent file
Comments
Comment #1
berdirComment #2
berdirOk, here is a first patch.
- Based on a completly new RESTful API.
- Support for detecting supporter target languages
- Select from 3 offers
- Redirect through manual payment page. Exact process can be improved, currently displays a message with a link.
- Implementation of callback URL that retrieves the translated order
- checkout information that displays the checkout information (currently the only thing displayed is the status
- Patch is huge due to the removal of a few files related to the old SOAP interface
ToDo (Mostly for follow-up issues)
- The redirect back to the site after doing the payment is currently broken, I contacted them about this and it looks like they started to update it but it's not documented yet how it works now. So you need to go back to the site manually.
- There is currently no possibility to configure anything on the checkout screen, e.g. those sliders or that you want a reviewer. Same for default options for those settings.
Comment #3
berdirUpdate.
- Appends the return_url to the payment link. Works correctly now with the redirect destination, but not yet if you have multiple jobs to check out, because there is currently no way to get the next url without removing it from the queue. Will open a follow-up issue for that.
- Verifies callback url's with the now provided api_sign and timestamp.
- Added logging of requests ( to check performance of their service)
I'll probably commit this soon and then start some follow-ups, like:
- The queue redirect stuff
- Checkout options like description texts and reviewers
- We have 4 translators now that do http requests and more are coming (e.g. the one for our own server, google, maybe lingotek). They currently have some overlapping stuff that we could unify in a DefaultRemoteTranslatatorController. For example a unified request() method that automatically supports mock/test/live remote URL's and logging. Or maybe a generic hook_menu() implementation for callbacks, that forward to a method on the controller.
Comment #4
berdirComment #6
berdirUpdated patch that adds support for descriptions and corrector setting.
Comment #7
berdirWhat's still missing are the settings on the right side of https://www.nativy.com/client/createorder.aspx. I think for a first version, it's enough if we implement them as simple selects. According to the documentation ( https://www.nativy.com/connectdoc/), the allowed values range between 1 and 80.
The user interface could probably also be improved a bit, by e.g. placing the translator image and the price information side by side.
And, there are currently no tests. Have a look at the mygengo/supertext/microsoft tests. There is a mock test module for each that returns example responses and the plugin has a setting that allows to override the service URL. Addiionally to what they are doing, tests for nativy should include: a) Saving the submitted order in a variable and confirm that the configured options have been submitted and b) return with/without corrector information depending on the submitted options.
Comment #8
berdirComment #9
corvus_ch commentedComment #10
berdirI'm currently not sure if we should make this a generic table (in a follow up), or throw it out. Any relevant information should be added as a job message. It can be helpful for debugging, though.
Needs a docblock.
Not necessary to repeat that 4x IMHO (the defaut value comment.). And needs a .
Trailing spaces.
Comment #11
berdirNoticed two issues while demonstrating the current version:
- After fetching the job manually, a incorrect/strange status was displayed (don't remember it exactly, some kind of error)
- The callback from nativy.com somehow didn't worked, even though we were on a publicly available server.
Comment #12
corvus_ch commentedApplyed review from comment #10
Comment #13
corvus_ch commentedFor the status thing I opened a new issue #1592138: Acces denied when checking translation status.
Comment #14
berdirOk, commited, we'll improve it further in follow-ups.
PS: When referencing issues, make sure to wrap it in [ ] so that it is linked automatically.