Adding a link to http://drupal.org/node/add/changenotice will make it easier. Perhaps a link to the http://drupal.org/node/1314040 instructions as well?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | change-records-rss-addlink-v1.patch | 1.22 KB | jhodgdon |
Adding a link to http://drupal.org/node/add/changenotice will make it easier. Perhaps a link to the http://drupal.org/node/1314040 instructions as well?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | change-records-rss-addlink-v1.patch | 1.22 KB | jhodgdon |
Comments
Comment #1
jhodgdonI'm adding this issue to the meta-issue #1217118: [meta] Followups for API change nodes
Personally I am not sure this is a very useful thing to do. Change notices are generally filed as a result of issues, and if we do have a link, it should probably be on the issue page, not the change notice list page? Or both?
We should probably have a link to http://drupal.org/node/1314040 on the node/add/changenotice page though, if we don't already.
Comment #2
jhodgdonThere seems to be some consensus that this is a good idea, so I'll take it on... at the moment waiting until
#1401136: Change notification "keyword" function doesn't work
is done, as this patch will conflict.
Comment #3
jhodgdontagging
Comment #4
jhodgdonI have this working on a test site. You can now see an "add a change record" link at the top of:
http://docs-infra-drupal.redesign.devdrupal.org/list-changes/views
http://docs-infra-drupal.redesign.devdrupal.org/list-changes/drupal
Note that it doesn't fill in the correct project. That would require significant coding (would have to do a form alter on the node add form to recognize the project as a URL get query, and I don't really think that's necessary).
Attached is a patch that fixes both this and
#1479576: [patch elsewhere] Provide a link to the RSS feed on change notices page
since they both are small changes to the same view.
After attaching, I'll apply the patch on the dev site and report back (at the moment it's running the views UI version of the view).
Comment #5
jhodgdonI tested the patch by reverting the view in the Views UI, verifying the RSS and add links disappeared, applying the patch, clearing the cache, and verifying the links came back.
I think this is probably ready to go, but if someone wants to give it a reality check, that couldn't be bad. :)
Comment #6
drummCommitted
Comment #7
jhodgdonThanks drumm! I was having trouble recruiting a reviewer, but it was sure an easy change. :)
Comment #8
drummDeployed.