Actually all instances of options in option_definition should use 'bool' => TRUE for options which are boolean.
This might/is a problem for all users of features, suddenly all features will get changed, which can really cause problems for some people.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | views-1472698-8.patch | 53.79 KB | tim.plunkett |
| #8 | interdiff.txt | 4.15 KB | tim.plunkett |
| #4 | 1472698-option-definition-bool.patch | 51.31 KB | dawehner |
| #1 | 1472698-option-definition-bool.patch | 51.52 KB | dawehner |
Comments
Comment #1
dawehnerHere is a first start, even I looked at all handlers/plugins.
Comment #2
tim.plunkettEither switch the default to a bool, or leave off the bool flag.
.
.
.
.
.
.
.
This just looks wrong.
Comment #3
dawehnerOkay let's convert the default values as well.
The last wrong is also a boolean, so what does this look wrong?
Just reread the patch twice, to be sure nothing was changed wrong.
git diff --color-words is quite helpful here.
Comment #4
dawehnerOkay this time with a patch :(
Comment #5
tim.plunkettMy comment about "link_to_node default" was just that we normally don't use conditionals for the defaults.
Whether or not something is default affects how it gets exported. If the selected option matches the default, it is left out of the export.
However, I just realized it's checking
$this->definition, not$this->optionsor something, so maybe it's not too big of a deal?Comment #6
tim.plunkettMy comment about "link_to_node default" was just that we normally don't use conditionals for the defaults.
Whether or not something is default affects how it gets exported. If the selected option matches the default, it is left out of the export.
However, I just realized it's checking
$this->definition, not$this->optionsor something, so maybe it's not too big of a deal?Comment #7
dawehnerYes, this is intended behavior.
For node: title you want to have the link enabled by default, though for node: nid you don't want it, though internally both use the same handler, so we need some kind of mechanism to control this.
Comment #8
tim.plunkettOkay, found a couple more instances, I've attached an interdiff to show my additions.
If you're okay with those, I think this is ready to go.
Comment #9
dawehnerThanks for the interdiff!
Your changes looks perfect, let's get it out!
Comment #10
chris matthews commentedThe Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue