This patch does a couple of things:
rocketship.install
- create dedicated taxonomies
- create dedidated content types with fields: initiative issue and initiative page
separate css in rocketship.css
separate js in rocketship.js
Some changes in the menu with a settings screen for storing the vocabularies.
Everything works out fine besides the display of the 'master tag' (another one works fine, eg 'language-ui'). I'm trying to find out why the issues are not tagged with D8MI because I asume they are tagged with it on d.o. Without this the tagcloud doesn't work yet.
Two questions I ask myself:
1: Maybe initiative issue and initiative page are not the best names for the content types (and the taxonomies aren't the best either), with the example http://ventral.org/paissues.
2: Do you want an upgrade path for this ? :)
Note, this patch makes the module still look for D8MI issues only, I tend to work on making that abstract in another patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | i1471406-12.patch | 34.9 KB | attiks |
| #8 | i1471406-8.patch | 13.5 KB | attiks |
| #7 | i1471406-7.patch | 11.56 KB | attiks |
| #5 | i1471406-5.patch | 11.21 KB | attiks |
| #4 | i1471406-4.patch | 9.92 KB | attiks |
Comments
Comment #1
gábor hojtsySome copy-paste issues and permissions missing as discussed in IRC.
Yeah, maybe initiative issue tags is not a great name for possible other uses. Also, an upgrade path would likely be great for at least me :D I have lots of content in books (like http://hojtsy.hu/d8mi/base-language-features and parent and children) and would hate to loose them to regenerate the whole thing. So if you can write an update that assumes people used book node types for pages and the other hard-coded things, that would be great :)
Also, the lead user thing will need to be configurable and/or removable. I filter that out in D8MI because it would give me proportionately very big visibility int the list and that is exactly counter to the goal :)
Comment #2
attiks commentedA follow up patch, but maybe getting out of scope: i'm planning on using this so i can easily track all projects i'm involved in, so i added a 'project' taxonomy and fields to both issues and pages.
I tried to keep it backwards compatible with the original version, but if you want to collect issues from multiple url's you can use something like
Comment #3
swentel commentedYeah, the idea is that those URL's are going to be configurable through the interface.
Comment #4
attiks commentedI added drupalorg_nid as well, easier to link from inside views
Some other ideas:
Comment #5
attiks commentedFind a way to get last updated date: fixed
Comment #6
attiks commenteddemo site re-installed: atix.be/rsdemo
Comment #7
attiks commentedadded a check to only update outdated nodes and bail out if no update is required
Comment #8
attiks commentedIgnore #7, use this one
Comment #9
kristen polComment #10
gddIt appears that all the patches after Gabor's first one are diffs from that point, and don't add the installer file itself. This is kind of confusing. Can we get a fresh patch that will work on a fresh branch?
Comment #11
gddHm, maybe I'm nuts but I can't get any of these patches to apply properly?
Comment #12
attiks commentedIncluded a patch against master, maybe this can help.
Comment #13
Anonymous (not verified) commentedHi - this is very cool, am playing with it to see if I can make the http://groups.drupal.org/marketing-drupal issue queues a little easier to see/navigate.
I manually applied the patch in #12 - worked all except the $project_tag_vocabulary was missing a field which the $issue_tags_vocabulary had:
'help' => $help,I also tried creating a hook_uninstall but got lost trying to find out the best way of removing vocabs and fields.
Has there been any more work on this anywhere you know of, or is there any planned? I'm also playing with backbone to make it nice and interactive to browse.
Comment #14
gábor hojtsyI made some one-off changes for my hojtsy.hu deployment, which I should probably port upstream (focused on running the D8MI initiative really, and just posted this in a "if you find it useful" capacity :) but I think attiks and swentel jumping on it at the same time discouraged both of them from keeping up because it was hard to sync efforts.
Comment #15
dsayswhat commentedHi all -
I'm late to the party here. I just started looking at Rocketship last week while attempting to help set up some sites for other D8 initatives. In so doing, I fixed the sitebuilding-related issues you're handling in the patches above in my own way, before I spotted this issue.
If you think that the patch in #12 is still worth pursuing, I'll be glad to assist in getting that completed. However, I just tried to apply it without success.
Here's what I've done on my own - perhaps it will suffice:
I've taken the Rocketship install that @no_angel has built for the WSCCI initiative, based on conversations she had with @svettes and others, and have exported a feature containing the content types for issue and issue (book) page, plus the taxonomy vocabulary. You can find the feature at https://github.com/dsayswhat/rocketship-config if that sounds like a reasonable approach.
I've also added a configuration form to this module allowing the selection of which taxonomy vocab to use for issue tags, and to configure the master tag to pull from d.o. I've got a patch uploaded over at https://drupal.org/node/2106083#comment-7938861.
Let me know if that sounds reasonable, if you want to include the content types in this module directly, with features, without features, or want to go in a different direction.
Comment #16
dsayswhat commentedSetting this to 'needs revew'
Comment #17
gábor hojtsyIMHO it would be great to do this step by step in a way that is reviewable. #2106083: Make taxonomy and d.o issue tag configurable is a good first step. I think other improvements from this issue would also be great, we should try and go step by step instead of big bangs.
Comment #18
lewisnymanI've split this patch into separate issues so it's more manageable:
#2277743: Create content types, fields and vocabulary on install
#2277745: Create default taxonomy on install
#2277741: Separate CSS and JS files
Comment #19
gábor hojtsy