The error occurs when line 179 runs a function that returns nodequeue_nodequeue_access($node->type) && nodequeue_queue_access($queue, $subqueue).

You would not expect the superadmin to get a response of FALSE, but it does

CommentFileSizeAuthor
#6 1470570-enabled-node-types-6.patch1.19 KBfizk

Comments

carlhinton’s picture

The error occurs when the following steps are followed:

  1. Create a node queue
  2. Select a number of node types that can be added to the node queue
  3. Add nodes of testtype
  4. Remove the testtype from the list of node types that can be added to the node queue
  5. Now try to remove the nodes of the testtype
  6. The result will be access denied

Suggested solution:
When the user removes the node type at step 4, the code needs to identify the existance of nodes of this type and ask the user if these should be deleted or not

carlhinton’s picture

Assigned: carlhinton » Unassigned
Status: Active » Needs review
amateescu’s picture

Version: 7.x-2.0-beta1 » 7.x-2.x-dev
Status: Needs review » Active

I agree with the suggested solution, but there is no patch here so setting back to active until someone steps up and creates a patch :)

pat redmond’s picture

confirming this is an issue.
The module need to either warn the user that removing a content type will delete those nodes from the list (as mentioned in #1), or prevent the user from removing content types which exist in the nodequeue.

finedesign’s picture

Also confirming this is an issue. I didn't setup the current site and didn't know only certain content types were available to a certain NodeQueue, so when I couldn't add a node, I just added the [nid: 123] manually. It worked, but when I realized it was not the correct content type, I could not remove it from the queue until I enabled that content type in the nodequeue settings.

fizk’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new1.19 KB

Here's a patch that displays an error message if these types of nodes exist. The user is asked to either enable the node type(s) or remove those nodes from the queue first.

fizk’s picture

Issue tags: +Nodequeue 7.x-2.x release blocker
fizk’s picture

Issue tags: -Nodequeue 7.x-2.x release blocker +Nodequeue 7.x-2.0 release blocker
othermachines’s picture

Status: Needs review » Active

@fzk, I could not duplicate this issue using latest 7.x-2.x-dev following the steps in #1. After unchecking the content type in the list of permitted content types, I was able to remove from the queue nodes belonging to that content type both as User #1 and a regular user with permissive role. I'll let you decide if this should be closed.

fizk’s picture

@othermachines Strange, I can't reproduce this anymore either...

fizk’s picture

Status: Active » Postponed (maintainer needs more info)

@CarlHinton, @finedesign, @Pat Redmond, If anyone can reproduce this using the latest 7.x-2.x-dev, please describe the steps to reproduce.

I'll close this after 7 days if we can't reproduce.

fizk’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: -Nodequeue 7.x-2.0 release blocker

Closing. If you can reproduce using the latest 7.x-2.x-dev, please describe the steps.