items_per_page ignored when cache enabled? [#1469074]

I'm not sure if this really is issue, however i suposse so.

How to reproduce:
- create some view with some items
- set pager to let's say 3, and enable time based cache for let's say 5 minutes
- go to the view page without items_per_page in url
- after first load the query or data are cached, and the items_per_page is ignored for next request

Could please somebody confirm or deny if they have same issue, and or if this is expectable behaviour. Anyway i wouldn't expect this kind of caching. I suppose the cache have some key, and the key should also work with the items_per_page somehow... Any help appreciated, thanks in advance.

Comment	File	Size	Author
#3	views-cachekeypatch-1469074-5694088.patch	655 bytes	morf2009
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

morf2009 CreditAttribution: morf2009 commented 6 March 2012 at 01:51

I made some quick research, and really.

File: plugins/views_plugin_cache.inc
Function: views_plugin_cache::get_results_key()

Line:
foreach (array('exposed_info', 'page', 'sort', 'order') as $key) {

Should be:
foreach (array('exposed_info', 'page', 'sort', 'order','items_per_page') as $key) {

Please correct me if i'm wrong. Thanks!

Comment #2

dawehner

German

CreditAttribution: dawehner commented 6 March 2012 at 08:12

Can you add offset as well?

Here is a tutorial how to create patch files: http://drupal.org/patch/submit

Comment #3

morf2009 CreditAttribution: morf2009 commented 6 March 2012 at 13:22

Status:

Active

» Needs review

File	Size
views-cachekeypatch-1469074-5694088.patch	655 bytes

Sure! Thanks for your quick reply. Here is the patch, let me know if there is anything else i can do :)

Comment #4

morf2009 CreditAttribution: morf2009 commented 7 March 2012 at 13:33

Does the patch meet the requirements?

Comment #5

dawehner

German

CreditAttribution: dawehner commented 7 March 2012 at 18:26

Version:	7.x-3.3	» 6.x-3.x-dev
Status:	Needs review	» Patch (to be ported)

Please don't push your issues, you know there are so many other issues, it's even hard to just get all the mail notifications...

Committed to 7.x-3.x, as it looks fine, though it would be kind of helpful to have this on 6.x-3.x as well.

Issue summary:	View changes
Status:	Patch (to be ported)	» Closed (outdated)

The Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue