In Endnote, to get name suffixes to display correctly (e.g., First Last, Jr. or First Last, III) you have to enter it as "Last, First, Jr." in the author field. I imported such an entry into biblio the other day and it did not result in "First Last, Jr." being displayed (unfortunately, I don't remember exactly how it was displayed instead).

Comments

rjerome’s picture

rjerome commented

I would have expected that to work. Is that the exact formating (Lastname, Firstname, Jr.)?

Ron.

jonmower’s picture

jonmower commented

In Endnote I usually use an output format like "F. Last". With a suffix, it should generally be "F. Last, Suffix":

If I enter "W.A. Goddard, III" Endnote displays "I. W. A. Goddard"
If I enter "W.A. Gaddard III" Endnote displays "W. A. G. III"
If I enter "Goddard III, W.A." Endnote displays "W. A. Goddard III" (but I've had to give up the comma between Goddard and III)
If I enter "Goddard, W.A., III" Endnote displays "W. A. Goddard, III" (which is the correct name)

In biblio, "Goddard, W.A., III" is displayed as "Goddard, W.A." (i.e. the suffix is not displayed)

rjerome’s picture

rjerome commented

Ok, that doesn't surprise me since the only suffixes I'm looking for are... Jr|Sr|Snr

Ron.

tatien’s picture

tatien commented

I have a similar issue here. Writing it as "Lastname, Firstname, Jr" displays it as "Lastname, Jr , Jr" (no firstname... and a strange space after the first "Jr").

tatien’s picture

tatien commented
Status: Active » Needs review

I have coded a fix to the _biblio_get_prefix function, here:

function _biblio_get_suffix(&$name) {
  $suffix = null;
  if (preg_match("/(.*[^, \.])[, \.]+(Jr|Sr|Snr|I|II|III|IV)\.?\s*$/", $name, $match)) {
    $name = $match[1];
    $suffix = $match[2];
  }

  return $suffix;
}
rjerome’s picture

rjerome commented

Strangely, If I enter the exact same string, it works fine and I get "Lastname, F. , Jr".

rjerome’s picture

rjerome commented
Status: Needs review » Fixed

I have committed the the changes suggested in #5.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Closed (fixed) » Active

@rjerome: is there no suffix support (on submission) in D6? biblio_parse_contributors()

rjerome’s picture

rjerome commented

Yes, there should be. Are you saying it's not working? There is a function called biblio_parse_author() in the biblio.contributors.inc file which handles this.

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented

yes, biblio_parse_contributors() calls biblio_parse_author(), and the latter doesn't account for suffix AFAICT?

The help text doesn't mention suffix at all, and after trying many different possible entry formats I could never get it to work (which led me to looking at the functions).
Maybe this is a better question -- is there any way to enter a name (with prefix, first, middle, last and suffix) that will populate those author fields correctly?

As it stands now, the user has to edit each author and correct the entry data so first name is in first, last name last, suffix is really recognized as suffix etc.

Lanae’s picture

Lanae commented
Version: 6.x-1.x-dev » 6.x-1.7

Even directly entering the suffix in the Suffix field when editing an author, doesn't work. The only way I could get the suffix to be displayed at all is to enter "Doe, Jr." as the last name.

rjerome’s picture

rjerome commented

Sorry, I didn't get a chance to address this issue prior the the 1.7 release since there was some urgency to get that out. I will look into it soon though.

Ron.

rjerome’s picture

rjerome commented
Status: Active » Fixed

fixed
http://drupal.org/cvs?commit=273022

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.