Closed (fixed)
Project:
Views data export
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
2 Mar 2012 at 22:25 UTC
Updated:
15 Sep 2014 at 06:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dmitriy.trt commentedPatch with implementation.
Comment #2
aoturoa commentedthanks Dmitriy.trt for the patch, exactly what i needed.
I made small change so the CDATA is not applied on empty content.
Sorry for not using git patch, but the code below is pretty self explainable.
Comment #3
klausiPatch looks RTBC to me, integrated the suggestions from #2.
Comment #4
dmitriy.trt commentedZero will not be wrapped with CDATA. It's just a guess. Please set back to RTBC if I'm wrong.
Comment #5
klausiRight, we should better check for the empty string instead of using empty().
Comment #6
dmitriy.trt commentedInteger zero can't get here, right? Asking because
0 != ''results inFALSEand integer zero still won't be wrapped. Sorry I don't have this module installed at the moment and can't dig into it with debugger or properly analyze the code.Comment #7
leo pitt commentedHi, it would be great if it were possible to apply CDATA to individual fields rather than all fields in the view.
Comment #8
junedkazi commentedOk so I need it to be based on per field. So I am attaching a patch for review.Also a cleanup as there were some + signs in the comments.
Comment #9
junedkazi commentedSetting it to needs review.
Comment #11
junedkazi commentedComment #12
steven jones commentedThis patch looks okay, but we need some tests to make sure this functionality works. There should be test for not-escaping certain fields, which would be a good basis for a test.
Comment #13
steven jones commentedHere's a patch for the testbot.
Comment #14
steven jones commentedThanks everyone, committed to 7.x-3.x.
Comment #15
steven jones commentedNow needs backporting.
Comment #16
junedkazi commentedComment #16.0
junedkazi commentedremoved comments that were potentially unrelated to the feature request/issue
Comment #18
steven jones commented@junedkazi thanks for the patch!