Following E_STRICT Warnings appear on storm/invoices

Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 118 of storm/storminvoice/storminvoice.theme.inc).
Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 122 of storm/storminvoice/storminvoice.theme.inc).
Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 126 of storm/storminvoice/storminvoice.theme.inc).
Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 141 of storm/storminvoice/storminvoice.theme.inc).
Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 145 of storm/storminvoice/storminvoice.theme.inc).
Strict warning: Only variables should be passed by reference in theme_storminvoice_list() (line 149 of storm/storminvoice/storminvoice.theme.inc).

Patch follows.

CommentFileSizeAuthor
#1 storm_invoice_e_strict-1463246-1.patch2.61 KBkfritsche

Comments

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new storm_invoice_e_strict-1463246-1.patch2.61 KB

Here the Patch.

juliangb’s picture

juliangb commented

I'm a bit confused by why these weren't picked up by the testbots, as I thought that they were set to E_STRICT, and there is a test that requests this page.

That said, seems like a logical change, so from my read through it looks fine.

I haven't tested, but I'm guessing you have.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Version: 6.x-2.x-dev » 7.x-1.x-dev

I committed this to 6.x-2.x.

Setting this to 7.x-1.x as we should commit this there too.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

I've pushed this into D7.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.