Add support for tokens module on twitter post.

This is definitely still an issue and something I'd like to see implemented as well. Can you re-roll against the 7.x-5.x-dev?

Set #370980: Include node type in post announcement as duplicate.

Here's a reroll. The original patch actually succeeded on 7.x-5.x-dev (with fuzz - just some line number changes). Here is the patch rerolled against 7.x-5.x-dev. Not quite sure if the interdiff is correct, but posting it anyway... I haven't been able to actually test that the functionality works, but at least we have an updated patch.

I think that this patch doesn't work as intended - I manually applied it to my 7.x-5.8 version of the twitter module, but it then gave me the token help at the top of my node/add forms (see attached screenshot). I think it may be that the form key is incorrect, so instead of $form['token_help'] it should be $form['twitter']['token_help'] to appear in the correct place? It also seemed to load really slowly and kept telling me that a script had become unresponsive, but not sure if that is related to this change.

I will do some testing when I get a chance, but I think needs work.

You should also use the '#dialog' => TRUE option in the form field to make it load in a popup instead of inline.

Thanks for the tip @Damien. I have updated the patch. It now displays the token help in a fieldset, and the tokens open up in a dialog. To hide and show the token replacements fieldset I had to update the twitter_post javascript. I don't actually know if the fieldset "REPLACEMENT PATTERNS" is necessary - I got it from the pathauto module. I also haven't tested whether or not the tokens are replaced correctly. Will get to that when I get some more time. Leaving it as 'needs work' because it probably does...

I have done some testing - created content and added tokens to the post to twitter field, and the tokens were rendered correctly in the tweet. I also set some default tokens in the twitter post admin page, and these were also tweeted correctly. UI feels ok to me.

I'm not sure how many people need to test it before RTBC can be set as the status, but this appears to work well.

I have 2 comments to make: Firstly as the Token module has over 800,000 installs (3rd behind Views & Ctools in terms of number of installs) should token be a requirement and drop the module's own replacements? Secondly, should the tinyurl replacement be dropped as all links submitted within tweets and direct messages, regardless of length, will be wrapped with t.co

@intrafusion: I don't think making it optional is that much of a deal, and it's definitely worth removing the URL shortening.

I have taken @foxtrotcharlie's patch from #7 and updated it by removing !tinyurl and altering the fields & descriptions to use token replacements rather than the module's in-built replacements.

Lets drop the token support and move the remove-TInyURL stuff into #2555819: Remove TinyURL integration.

@DamienMcKenna what's the status of this issue? What needs to be done to get this into the module?

The update script needs to do a search/replace on the variable, rather than force-update it to a new string.

I'm contemplating dropping the 7.x-5.x branch and focusing effort on the update script to 7.x-6.x, because it already has token support.