At the end of an order I get to (say) checkout/13/complete. Whether authorised or admin, and independent of payment method, the page only shows the title "Checkout complete" and no other message. Notification emails are sent ok. The Completion message checkout pane looks suspicious: I figure I should see some configuration options but none appear (refer screenshot).

I *should* be seeing the default completion message (your order is #, etc.) Any idea why this isn't appearing?

#5 commerce-1434868-5.patch817 bytessheise
PASSED: [[SimpleTest]]: [MySQL] 3,567 pass(es). View
Screen Shot 2012-02-10 at 1.56.47 PM.png60.54 KBjonathan_hunt
Members fund testing for the Drupal project. Drupal Association Learn more


rszrama’s picture

Yeah, not sure - something's missing there. Are you running any other modules on there?

sheise’s picture

I ran into this problem on 2 different sites and now realize what the problem is. Both sites were upgrades from D6 where filter formats where stored numerically and were not upgraded to the D7 machine name formats of "filtered_html, full_html, plain_text". So the settings form in question never gets rendered properly. I'm not sure what the best quick option is though without messing up all your existing content.

rszrama’s picture

On Drupal Commerce 1.3, this should be fixed I believe. Can you confirm?

sheise’s picture

Forgot to specify, but I am running Drupal Commerce 7.x-1.3 and still having the problem.

sheise’s picture

Status: Active » Needs review
817 bytes
PASSED: [[SimpleTest]]: [MySQL] 3,567 pass(es). View

Here's a patch.

Status: Needs review » Needs work

The last submitted patch, commerce-1434868-5.patch, failed testing.

rszrama’s picture

Version: 7.x-1.2 » 7.x-1.x-dev

Needs to be tested against head.

rszrama’s picture

Status: Needs work » Needs review

#5: commerce-1434868-5.patch queued for re-testing.

vasike’s picture

jonathan_hunt’s picture

Patch in #5 works for me on 7.x-1.3, thanks.

rszrama’s picture

Status: Needs review » Fixed

Wow, thanks Steven. I have no clue how that function slipped beneath our radar, but that's what we've needed all along. : )

Welcome to the committers log!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

JulienF’s picture

Version: 7.x-1.x-dev » 7.x-1.8
Issue summary: View changes
Status: Closed (fixed) » Needs work

Hello All,

I just noticed this bug with one custom install profile I'm creating and the issue wasn't related to the input filter but with the variable commerce_checkout_completion_message in the database.

at the very begining of the funtion commerce_checkout_completion_message_pane_settings_form($checkout_pane) - file we have this line
$message = variable_get('commerce_checkout_completion_message', commerce_checkout_completion_message_default());

In here the variable is set yet it returns a simple string instead of an array as expected by the rest of the function (specifically those lines):
'#access' => filter_access(filter_format_load($message['format'])),

    '#default_value' => $message['value'],
    '#format' => $message['format'],

Which was causing the problem.

In order to solve the problem I had to delete the row in the variable table and it worked well back again... I still haven't found the time to see where is this variable being stored at install and the quick fix I'll apply for now is to delete it at the end of the install profile tasks but a cleaner fix is highly appreciated.


rszrama’s picture

Status: Needs work » Closed (fixed)

Thanks for the info, Julien.

mdolnik’s picture

FYI, I had the same issue with the settings missing with 7.x-1.10 as per the screenshot.
I tried many of the suggestions here and elsewhere with no luck,
to eventually notice the administrator permission: 'Use the Filtered HTML text format' was unchecked... Checking this brought the proper menu back.