"Hide rewriting if empty" always thinks zero is empty

Is this still required on the current version? There was some logic applied recently. Additional the patch does definitive not apply anymore.

Is this still required on the current version? There was some logic applied recently. Additional the patch does definitive not apply anymore.

The patch doesn't address all situations.

I checked both a non-empty field rewritten to 0, and an empty field rewritten to 10, with all possible combinations of the checkboxes.

This adds a helper function, because the !== 0/'0' pattern appears in 4 distinct places, one of them wrong.

+++ b/handlers/views_handler_field.incundefined
@@ -1062,6 +1062,27 @@ If you would like to have the characters %5B and %5D please use the html entity
+    if ($check_empty) {
+      $empty = empty($value) && $empty;
+    }

I strongly debated leaving this part out of the function and just calling empty() in the code, but I do believe this is cleaner.

It would be kind of cool to extend the already existing tests. This code has to many cases that you can be sure all the time.
Introducing a helper function definitive makes things a bit clearer.

I'm working on the tests.

Alright, I went a little overboard on the tests, but they needed to be cleaned up.

Should have about 2 fails on the test only patch, and all passes on the other.

Well you'd have to run it locally to see that. Simpletest > Views Handler > Field.

Triggering the testbot.

Reroll

In IRC @dereine suggested switching the default value for is_value_empty().

     $view->field['name']->options['alter']['alter_text'] = TRUE;
-    $view->result[0]->{$column_map_reversed['name']} = "";
-    $random_name = $this->randomName();
     $view->field['name']->options['alter']['text'] = $random_name;
+
+    // Test a valid string.
+    $view->result[0]->{$column_map_reversed['name']} = $random_name;
+    $render = $view->field['name']->advanced_render($view->result[0]);
+    $this->assertIdentical($render, $random_name, 'If the rewritten string is not empty, it should not be treated as empty.');
+

Just a small issue: It could be that the rewritten value is used, as both are equal, what about creating another random name for the actual value?

Duh, I switched which function calls used the third parameter, but not what they were passing. Those fails were a good thing :)

Also included the suggestion from #20.

The patch is fine and has a phenomenal test coverage. Let's get it in! Thanks for the work!

The Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue