Right now, each JS plugin needs to do var settings = Drupal.settings.fullcalendar[fullcalendar.dom_id];. We can just pass that in and make it cleaner.

CommentFileSizeAuthor
#1 fullcalendar-1428536-1.patch2.72 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new fullcalendar-1428536-1.patch2.72 KB
aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community 
+++ b/fullcalendar_options/js/colorbox.fullcalendar.jsundefined
@@ -1,11 +1,11 @@
     }
+    settings = settings.colorbox;

+++ b/fullcalendar_options/js/fullcalendar_options.fullcalendar.jsundefined
@@ -1,8 +1,11 @@
+    }
+    var options = settings.fullcalendar_options;

This in not rly consistent, I would choose settings in the second one, to prevent name clashes with the js "options:"
Offcourse this means we need to rename some stuff in the js file.

But I'll trust Tim with this :)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

In some cases, we just want them as settings, to conditionally add into options.
Other times, the values are all we need, so they're passed directly.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/fullcalendar.git/commit/3ff12bd

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.