reopening to extend on the initial scope

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

guillaumev’s picture

Status: Active » Needs review
FileSize
3.25 KB

Here is the patch...

kevinquillen’s picture

Will review soon.

chertzog’s picture

Status: Needs review » Reviewed & tested by the community

I have applied this and have been using it for a while with no problems.

kevinquillen’s picture

Is this combined with the patch in the Features Integration issue? Some of the code looks the same. If so, can we split them into two clean patches?

http://drupal.org/node/1424534

guillaumev’s picture

I just tested this again and:

  • It is working just fine.
  • The code in this patch is NOT combined with the Features Integration issue, so it is a clean patch.

Can we commit this ?

Thank you,

kevinquillen’s picture

Status: Reviewed & tested by the community » Fixed

Sorry about that. This has been committed to dev. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pelicani’s picture

Issue summary: View changes
Status: Closed (fixed) » Needs review

This implementation doesn't appear to contain any action.
Rather it is a condition for the existence of the custom permissions.
What if we want a rule to add a custom permission based on a condition?
maybe another custom publish option.
This doesn't appear possible with this module on download.

I did find that an advanced action can be created.
But I can't get it to trigger.
i.e. it won't appear in the node trigger options.

I tried researching doing this in dv6, a while ago, and made a hack to make it work.
https://drupal.org/node/873928
Then, a patch was made by arcaneadam, the maintainer, nice.
I'll have to look at that.
Can we reopen this ticket to mark the decision to include these options for dv7?

I found 3 other dv7 posts asking for similar.
I'd like to mark them as duplicate of this and track status in this ticket.
https://drupal.org/node/1906908
https://drupal.org/node/2091641
https://drupal.org/node/1955696

thanks in advance,
michael

kevinquillen’s picture

kevinquillen’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kevinquillen’s picture

n/a

kevinquillen’s picture