The getInfo() method of ContentCrud tests throws PHP notices, has to be declared as public static.

CommentFileSizeAuthor
#5 cck.test-notices.5.patch1.19 KBsun
cck.test-getinfo.0.patch2.63 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Sorry, but bump ;)

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

That said, a similar issue also exists in D7:

# Strict warning: Declaration of ContentMigrateTextTestCase::setupField() should be compatible with that of ContentMigrateTestCase::setupField() in _registry_check_code() (line 3046 of includes\bootstrap.inc).
# Strict warning: Declaration of ContentMigrateListTestCase::setupField() should be compatible with that of ContentMigrateTestCase::setupField() in _registry_check_code() (line 3046 of bootstrap.inc).

However, in that case, the function signature of the overridden method is not identical to the parent/original.

Anyway, let's fix D6 first.

yched’s picture

yched commented
Status: Reviewed & tested by the community » Fixed

Committed to 6.x-2.X & 6.x-3.X, and fixed the D7 notices as well. Thanks !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-2.x-dev » 7.x-2.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new cck.test-notices.5.patch1.19 KB

Fixed the new ones that got introduced.... ;)

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Version: 7.x-2.x-dev » 7.x-3.x-dev
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

For #5.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #1277262: Plan for CCK 7.x-3.0 release