Hej,

after I enable "aggregate Javascript files" flexslider don't work

you have also the problem?

kind regards
drew

Comments

minorOffense’s picture

Status:Active» Postponed (maintainer needs more info)

I've tested all the modules with aggregate js on and I'm not seeing an issue.

Can you supply which browser you're using and if there are any javascript errors?

minorOffense’s picture

Status:Postponed (maintainer needs more info)» Closed (works as designed)

Haven't heard back nor have I heard of any other reports so I'll assume this is an isolated incident or it was fixed in a newer release.

Please reopen if that is not the case.

Thanks!

sgerner’s picture

Version:7.x-1.x-dev» 7.x-1.0-rc3
Status:Closed (works as designed)» Active

I'm having the same issue. When I turn on js aggregation none of the slides are visible. I've tested with Chrome 19, Firefox 12, and IE 9. I've also tried removing all the other js libraries I was loading just to see if anything was clashing, but the problem persists. When I looked at the CSS, all of the li's containing the slides (.flexslider .slides > li) are set to "display: none".

marcoka’s picture

using drupal 7.14, i can not confirm this. i suggest testing it on a clean install. maybe other modules interfere.

minorOffense’s picture

Status:Active» Postponed (maintainer needs more info)

Can you try using a stock theme (Bartik for instance)? And perhaps provide a list of modules you're using?

minorOffense’s picture

Status:Postponed (maintainer needs more info)» Closed (cannot reproduce)
topham’s picture

Status:Closed (cannot reproduce)» Active

I ran into this same issue, unfortunately the site in question has a considerable number of modules and inter-dependencies and disabling a few modules to test is time consuming and difficult.

However, I spent a bit of a time dropping in a few dsm (from Devel) around the code and it looks to me like the underlying problem is related to Flex Slider / flexslider_views. From what I can tell when you're using flexslider_views it's never calling flexslider_add() and therefor the library isn't be registered for the page.

I modified flexslider_views.module to add the following function

<?php
function flexslider_views_init() {
 
flexslider_add();
}
?>

And my problem with Flexslider not working with aggregation goes away. This might be over-kill or the wrong spot to include the call.

minorOffense’s picture

Status:Active» Closed (won't fix)

Try 2.x

The rendering pipeline has been redone. Unless some posts a patch for 1.x I won't be fixing it.

Perignon’s picture

Version:7.x-1.0-rc3» 7.x-2.0-alpha3
Status:Closed (won't fix)» Active

This is still an issue even under 2.0-alpha3. I spent 2 hours tonight trying to figure out why my production server wasn't showing images when my dev server was - then I realized that I always turn off CSS/JS aggregation on my dev servers. Enabling aggregation makes the slideshow disappear. Adding the code proposed in #7 works and fixes the problem.

MXT’s picture

I was having the same issue when javascript aggregation was active.

I resolved in this way:

Stable release 2.2.0 for flexslider jquery plugin was released on august 2013, but some times later there was another commit after stable release, only for minified version of the file (jquery.flexslider-min.js).

If you download this very latest version and use this instead of the "old" one, all works fine.

You can download this version here:

https://github.com/woothemes/FlexSlider/blob/ca347d49f3656ff7ba7ea1a043f...

Hope this help

minorOffense’s picture

#7 would have flexslider added on all pages. Using hook_init like that may be a temporary work around but not a long term solution.

Since I have flexslider working in a cached environment with views it's tough to debug this. Is the caching on your views turned on by any chance?

In your browser, is there a 404 or something when trying to load a js file? Maybe add some alter hooks for add css / add js to see which libraries are loading with aggregation on?

joeeastham’s picture

I had this issue too. Sadly, I don't have time to really investigate at the moment, but I can confirm that turning off views caching fixed the issue for me.

nicoz’s picture

Priority:Normal» Critical
Issue summary:View changes

As per Priority levels of issues, I am upgrading this issue to critical.

Critical bugs either render a system unusable (not being able to create content or upgrade between versions, blocks not displaying, and the like), cause loss of data, or expose security vulnerabilities. These bugs are to be fixed immediately.

As per #10, a simple library update is all that is needed. Maintainers, can we get this rolled into the latest stable as this issue is keeping sites from going live?

minorOffense’s picture

Title:don't work with aggregate Javascript files» Update documentation to point to the latest version of FlexSlider to avoid js aggregation issues
Component:Code» Documentation
Priority:Critical» Normal

We don't package FlexSlider into the module so there's nothing for us to do.

As for caching and views, Views doesn't allow us to attach libraries to blocks or other views items. So in some cases caching views can break the loading of the flexslider library. Sadly nothing we can do as this is a views bug.

As for the update minified library, we can add docs about it and update the example make file but other than that it's up to WooThemes to make a new release for FlexSlider with the fix in place.

plato1123’s picture

What's the best fix for this one, #10?

imoreno’s picture

#10 did the trick for me, all is working as expected with aggregation turn on.

afemath’s picture

#10 worked perfectly. Thanks

nicxvan’s picture

#10 worked for me on one site but not another, turning js aggregation on stops the rotating.

BBC’s picture

#10 worked for me as well. Thanks much!

nicxvan’s picture

Just a note on#18, environment indicator was interfering with the flexslider js.

nemanja_legenda’s picture

I had same issue, but then i downloaded flexslider 2.3.0 and all issue related with aggregation are gone. You can download new version from this url https://github.com/woothemes/FlexSlider.

nemanja_legenda’s picture

Status:Active» Fixed

I had same issue, but then i downloaded flexslider 2.3.0 and all issue related with aggregation are gone. You can download new version from this url https://github.com/woothemes/FlexSlider. Hope this will help someone.

nemanja_legenda’s picture

Correction, version is 2.2.2

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.