It didn't look like the password_policy.test file had been updated to Drupal 7. I added the test to the .info file, ran it through Coder Upgrade, then added calls to module_load_include() for each of the necessary constraint include files called within PasswordPolicyTest.

Each test group is currently returning 19 fails. I'll start looking at those next.

CommentFileSizeAuthor
#3 upgrading_tests-1414414-3.patch13.91 KBmatt v.
#1 upgrading_tests-1414414-1.patch13.94 KBmatt v.
upgrading_tests.patch12.94 KBmatt v.

Comments

matt v.’s picture

matt v. commented
StatusFileSize
new upgrading_tests-1414414-1.patch13.94 KB

I've updated the tests to reflect paths that changed in the Drupal 7 version. I also added the Current Password to tests of the change password process, as required by Drupal 7.

All tests now pass for me.

erikwebb’s picture

erikwebb commented
Status: Needs review » Needs work

I'm not able to apply. Can you re-run the patch on the latest 7.x-1.x pull?

matt v.’s picture

matt v. commented
Status: Needs work » Needs review
StatusFileSize
new upgrading_tests-1414414-3.patch13.91 KB

Oops, sorry, I forgot to pull the latest updates before generating that last patch. Here's an updated version.

erikwebb’s picture

erikwebb commented
Status: Needs review » Fixed

I'm having a failure, but this is a great start.

http://drupalcode.org/project/password_policy.git/commit/a1ed516

matt v.’s picture

matt v. commented

For what it's worth, I updated the tests on a site using Drupal 7.0. All the tests definitely pass on that version; I just reconfirmed.

When I test the same version of Password Policy on a site with the latest version of Drupal (7.10), the testSelfChange fails. It appears that something changed between Drupal 7.0 and 7.10 that's affecting that test.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.