Add password field for generated users

I'm not sure why your patch fails, but patches should always go against HEAD of the latest version.

+++ b/devel_generate.inc
@@ -11,8 +11,10 @@
+ * @param $pass
+ *  A string to be used as common password for all generated users. Defaults to NULL.

This comment line is >80 chars.

+++ b/devel_generate.inc
@@ -45,7 +47,7 @@ function devel_create_users($num, $kill, $age = 0, $roles = array()) {
-        'pass'    => NULL, // No password avoids user_hash_password() which is expensive.
+        'pass'    => NULL, //No password avoids user_hash_password() which is expensive.

If you want to fix this, then please fix it correctly.

+++ b/devel_generate.inc
@@ -99,6 +101,11 @@ function devel_create_users($num, $kill, $age = 0, $roles = array()) {
+        // Assign password, if set
+        if (!is_null($pass)) {
+          $account->pass = $pass; // Reset the password to an unencripted string
+        }

Comments need to be on a line of their own, start with a capital letter and end with a dot. Even if this is not strictly followed elsewhere, we'd like new code to adhere to the coding standards.

Why "Reset"?

Please use is_set() rather than !is_null(), it's more efficient.

@kurkuma: Please use the issues queue, not private messages.

As to your question about why D8: fixes and new features should always go to the newest version, so that an upgrade doesn't suddenly turn out to be a downgrade.

That said, you can try posting a patch prepared with 7.x-1.x-dev, because Devel for D7 and D8 are still pretty close.

#2: devel_generate_generateduserspassword-1398664-1.patch queued for re-testing.

#5: devel_generate_generateduserspassword-1398664-5.patch queued for re-testing.

Any news on this? I really need to assign passwords to my generated users. Is there any temp way of do it? Hashed passwords can't be inserted via MySQL so I have no idea what else to do.

We're waiting for a patch that passes and that takes the comments into account.

So there is no temp solution?

Not that I know of, but you're certainly welcome to propose one.

Here is a patch for 8.x-1.x.

@warmth: Please review and test!

I don't have any Drupal 8 installation now to test it, if you port it to D7 I could try it...

tagging

I applied the patch and tested creating 5 new users.
All the users created with the password filled on the text area.

I need Moshe to chime in here.

Looks fine. Needs test coverage?

Committed. I would rather start taking potential testing cases from the doc me and @pcambra proposed for this weekend's event and convert them into issues.

Downgrading version field to 7.x-1.x to see if the patch at #2 still applies.

Just saw it again and the paths of patch #2 are wrong. Waiting for @kurkuma to re-roll a new one.

@kurkuma, for Drupal 8, I just verified that generated users can sign in with the given password.

Patch #27 works fine. Committed at 7.x-1.x at http://drupalcode.org/project/devel.git/commitdiff/1d4e2ef

Thanks!