Required for:
#1397960: Combine storm attribute module into the storm module
#1392484: Separate Storm Knowledgebase into separate project

This issue will move the installation of specific attributes into the modules that they are used.

CommentFileSizeAuthor
#13 storm--attributes-db-v11.patch69.39 KBjuliangb
#12 storm--attributes-db-v10.patch69.01 KBjuliangb
#11 storm--attributes-db-v09.patch67.74 KBjuliangb
#9 storm--attributes-db-v6.patch66.75 KBjuliangb
#8 storm--attributes-db-v4.patch66.73 KBjuliangb
#6 storm--attributes-db-v3.patch63.53 KBjuliangb
#4 storm--attributes-db-v2.patch63.52 KBjuliangb
#2 storm--attributes-db.patch63.53 KBjuliangb
#1 storm--kb-attributes.patch3.85 KBjuliangb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Active » Needs review
FileSize
storm--kb-attributes.patch3.85 KB

This patch just handles the Storm knowledge base domain, to test.

I'll add to it later for the other domains.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
FileSize
storm--attributes-db.patch63.53 KB

This patch needs testing.

It moves all installation of attributes into the modules that use them, and the installation of the actual stormattribute table into the storm module.

It seemed more logical to move the installation of the actual table at the same time as moving the installation of the attributes.

Status: Needs review » Needs work

The last submitted patch, storm--attributes-db.patch, failed testing.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Needs work » Needs review
FileSize
storm--attributes-db-v2.patch63.52 KB

Removed whitespace errors.

Status: Needs review » Needs work

The last submitted patch, storm--attributes-db-v2.patch, failed testing.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Needs work » Needs review
FileSize
storm--attributes-db-v3.patch63.53 KB

Corrected syntax.

Status: Needs review » Needs work

The last submitted patch, storm--attributes-db-v3.patch, failed testing.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Needs work » Needs review
FileSize
storm--attributes-db-v4.patch66.73 KB

The exceptions were caused by no attributes being present, as in the tests only the storm attribute module is installed. This should fix.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
FileSize
storm--attributes-db-v6.patch66.75 KB

This version of the patch fixes a problem in stormticket when no updates are pending.

Also refixes the whitespace errors that have found their way in again.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Needs review » Needs work

Has to be rerolled.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Needs work » Needs review
FileSize
storm--attributes-db-v09.patch67.74 KB

Reroll to account for changes from last patches committed.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
FileSize
storm--attributes-db-v10.patch69.01 KB

Added attribute uninstalls.

juliangb’s picture

juliangb CreditAttribution: juliangb commented
FileSize
storm--attributes-db-v11.patch69.39 KB

Added descriptions to the database update functions (display when updating via drush).

juliangb’s picture

juliangb CreditAttribution: juliangb commented
Status: Needs review » Fixed

Tested on new install, upgrading from 6.x-2.x-dev and from 6.x-1.37.

Committed to 2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.