It seems that using the system block style, I can not get the title of my content panes to disappear.

On the pane settings form I have checked the box to "override title" and typed < none > in the box, but the title still shows.

I then went to block settings (ew!) and also configured the blocks to have their titles hidden, just incase the block style pulled the setting from block settings instead of pane settings, but the titles still show on the panes.

Is it possible to hide pane titles when using the default "system block" style? I think I remember this working in the past, perhaps a new bug.

(It looks like the "Override title" setting *does* work if all you want to do is change the title - it's just the "none" that doesn't seem to work.)

edit: it looks like the "none" does still work when using "No style".

Files: 
CommentFileSizeAuthor
#11 panels-1397076-hide-pane-title-11.patch474 bytesvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]

Comments

merlinofchaos’s picture

Oh this is probably because blocks use $block->subject and panes use $block->title -- maybe if the title is empty it doesn't get moved to subject and the original title sticks or something.

jenlampton’s picture

Status:Active» Needs review
StatusFileSize
new464 bytes

That sounds about right.

I found an

if (!empty($content->title))

Which looks like it prevents an empty title from becoming an empty subject.
Is there any harm in removing that check entirely?

merlinofchaos’s picture

That might cause a fail if override title is NOT checked?

Letharion’s picture

Status:Needs review» Needs work
jenlampton’s picture

Version:6.x-3.x-dev» 6.x-3.9

- Overriding the title with text works as expected.
- Overriding the title with "none" removes the title.
- Not overriding the title lets the block subject show through.

What else should I test to get this possible error?

jenlampton’s picture

Version:6.x-3.9» 6.x-3.x-dev
Status:Needs work» Needs review

patch still applies to latest version of panels.

jenlampton’s picture

Version:6.x-3.9» 6.x-3.x-dev

still adding this patch to every site I deploy with panels (and that's all of them) :)

jenlampton’s picture

Patch stopped applying cleanly. rerolled.

merlinofchaos’s picture

There's a different patch in http://drupal.org/node/1912174 for D7 (probably this one never gets seen because I have not been paying much attention to D6 lately, sadly)

merlinofchaos’s picture

Issue summary:View changes

added results of more testing

DamienMcKenna’s picture

vijaycs85’s picture

StatusFileSize
new474 bytes
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es).
[ View ]
Sharique’s picture

Status:Needs review» Reviewed & tested by the community

The patch looks good to me.