Closed (fixed)
Project:
FullCalendar
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Jan 2012 at 16:03 UTC
Updated:
19 Jan 2012 at 17:30 UTC
Jump to comment: Most recent file
In IRC aspilicious mentioned #1220830-1: Minor performance improvement for _hs_taxonomy_hierarchical_select_terms_to_options() which moves the module_exists call outside of the foreach to save function calls.
I double checked the code base, and all of the module_exists are outside loops, as well as all but one of the module_implements calls.
The one that was in a loop turns out to be completely unnecessary, since the reason for it was removed here http://drupalcode.org/project/fullcalendar.git/blobdiff/ce76580..8b9eb10...
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fullcalendar-1395252-2.patch | 1.24 KB | tim.plunkett |
| #1 | fullcalendar-1395252-1.patch | 1.23 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettComment #2
tim.plunkettWhoops, missing the $entity in module_invoke_all.
Comment #3
aspilicious commentedLooks ok code wise. If it's tested this is good to go.
Comment #4
tim.plunkettFixed!
http://drupalcode.org/project/fullcalendar.git/commit/57d0e0263c72e2b7ce...