What is it for? I see code is there since 5.x-2.x ( commit 02f31e3, precisely), but what is it for?
It has 022 selector specificity, which makes it difficult (and heavy on client-side performance) to override.
Proposed patch just removes it, I don't know what it is used for but it doesn't break my project.

CommentFileSizeAuthor
#1 1393782-panels-node-divs-margin-and-paddin-are-reset.patch648 bytesbarraponto

Comments

barraponto’s picture

barraponto
he / him
commented
Status: Active » Needs review
StatusFileSize
new 1393782-panels-node-divs-margin-and-paddin-are-reset.patch648 bytes
barraponto’s picture

barraponto
he / him
commented
Title: Node divs have styles "reset" » Node divs have margin and padding reset
merlinofchaos’s picture

merlinofchaos commented

In Drupal 7 it can probably be removed.

These exist because the default theme in Drupal 5 and 6, Garland, has some obnoxious margins on .node to make things fit. They're an example of the poor design of Garland's CSS. Bartik should be much more sane.

barraponto’s picture

barraponto
he / him
commented
Assigned: Unassigned » barraponto
Status: Needs review » Needs work

Yet Garland is still a core theme. Will test, then see if we can get away with less specific selectors.

merlinofchaos’s picture

merlinofchaos commented

It's a core theme but it's not THE core theme anymore, so I'm not as concerned with correcting for it.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Assigned: barraponto » Unassigned
Issue summary: View changes
Status: Needs work » Reviewed & tested by the community
Issue tags: +TX (Themer Experience)

Patch from #1 still applies and is still relevant.
Now we live in a world where themers are trying to work on the tinier possible components and selectors, this is really annoying.

(Same patch also applies on 8.x-3.x if it matters)

  • japerry committed 2d9a281 on 7.x-3.x authored by barraponto 
    Issue #1393782 by barraponto, DuaelFr: Node divs have margin and padding...
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Thanks for raising the attention of this. Yah, Garland isn't used nearly as much anymore. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented

Added old related issue because it shows up earlier when searching for this change.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Related issues: +#232608: "div.panel-pane div.node" style line should be removed
esolitos’s picture

esolitos
he/him
Primary language Italian
Location Trondheim
commented

Oh wow...