I'm seeing an issue when enabling the Workbench module, without Panels, but with Page Manager. When ctools_plugin_api_info() is called, the $version variable retains its value from the previous module (see below). This leads to the issue found here: #814528: Missing dependency on Panels in Features with one page in Page manager.

      // This is added to make hook_views_api() compatible with this, since
      // views used a different version key.
      if (isset($info['version'])) {
        $version = $info['version'];
      }
      else if (isset($info['api'])) {
        $version = $info['api'];
      }

      if (!isset($version)) {
        continue;
      }

Patch forthcoming.

CommentFileSizeAuthor
#2 ctools-1369082-02.patch560 bytesjhedstrom
#1 ctools-1369082-01.patch423 bytesjhedstrom

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new ctools-1369082-01.patch423 bytes

This patch resolves the issue of the workbench module returning default pages without the panels module enabled. It presumably resolves #814528: Missing dependency on Panels in Features with one page in Page manager as well.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
StatusFileSize
new ctools-1369082-02.patch560 bytes

This patch simply initializes $version = NULL at the beginning of the loop instead of the approach in #1.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed and pushed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jzornig’s picture

jzornig commented
Status: Closed (fixed) » Active

I'm using the fserver project which is a feature that contains a views style plugin. I found that this patch to ctools prevents the views style plugin from being recognised. If I back out just this one change in the ctools rc2 it resolves the issue.
See below for the issue at fserver.
http://drupal.org/node/1416178#comment-5753902

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Closed (fixed)

I'm not really sure how this would have broken this.
Can you open a new issue with steps to reproduce? Or at least how you deduced that this was what broke it.

aubjr_drupal’s picture

aubjr_drupal commented
Status: Closed (fixed) » Active

I was having issues with D7 and fserver and came across this thread.

The answer to #6 appears to be just commenting out the $version = NULL and rolling back the patch in #2.

http://drupal.org/node/1490740 had a precis of their deduction process.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Closed (fixed)

Great, that issue can be the follow-up, this issue can stay closed.