The following status message shows up (see screenshot) but I cannot close it without page refresh.

Also I am getting error message in javascript console "ok is undefined (sites/all/modules/media/js/media.popups.js?v=7.x line 105)".

CommentFileSizeAuthor
#3 1364640.media_popup_js.3.patch648 byteskatbailey
#1 quickfix.patch566 byteschi
media.png24.65 KBchi

Comments

chi’s picture

chi commented
Status: Active » Needs review
StatusFileSize
new quickfix.patch566 bytes
adamgerthel’s picture

adamgerthel commented

I'm having the exact same problem using the latest unstable version (2012-Jan-13). It works flawlessly using english, but not any other language.

Update: Patch didn't do anything to help

katbailey’s picture

katbailey commented
StatusFileSize
new 1364640.media_popup_js.3.patch648 bytes

Here's a slightly modified version of the patch which is more consistent with the use of Drupal.t elsewhere in the code (i.e. checking that it's there first, though I'm not sure how necessary that really is).
Steps to reproduce the problem:

  1. Enable a language other than English and translate the string 'OK' as something other than 'OK', e.g. 'Ok'
  2. Then try to use the media popup to upload an image.
  3. It dies a javascripty death after you hit the upload button.

This is because Drupal.t is used when assigning the 'OK' property, but not when accessing it.

@AdamGerthal did you clear your browser cache and ensure you had the altered version of media.popups.js when you tested this?

adamgerthel’s picture

adamgerthel commented

You were right, clearing the cache fixed it. The patch works

dddave’s picture

dddave commented
Assigned: chi » Unassigned
Status: Needs review » Reviewed & tested by the community

Unless someone can point out wrongful coding this patch works exactly as advertised and solves this borderline critical bug. Thanks!

max_d’s picture

max_d commented

patch #3 successfully fixes the exact problem in media 7.x-1.1

prins310’s picture

prins310 commented

Patch #3 successfully fixed this problem in media 7.x-1.1 for me as well. Many thanks!!

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed #3 to Git.

http://drupalcode.org/project/media.git/commit/423861a (7.x-2.x)
http://drupalcode.org/project/media.git/commit/6c15ed2 (7.x-1.x)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

alibama’s picture

alibama commented
Status: Closed (fixed) » Active

confirming that the latest 7.x-2.x branch does not work on mac chrome or safari - updated database, cleared cache multiple times, restarted browsers... tried adding media_browser_plus to see whether that might do anything useful... no such luck... this is pretty critical

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Closed (fixed)

Please file a new issue with exactly what's going wrong, rather than re-opening an issue that's been closed for a year.